Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9371010: Make google_update.gyp write shared files to SHARED_INTERMEDIATE_DIR (Closed)

Created:
8 years, 10 months ago by Ryan Sleevi
Modified:
8 years, 10 months ago
CC:
chromium-reviews, amit, robertshield, bradn
Visibility:
Public.

Description

Make google_update.gyp write shared files to SHARED_INTERMEDIATE_DIR BUG=97186 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=121396

Patch Set 1 #

Patch Set 2 : Add .h to target as well #

Patch Set 3 : Add comma #

Patch Set 4 : Update DEPS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -77 lines) Patch
M chrome/browser/DEPS View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/first_run/first_run_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/first_run/upgrade_util_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/google/google_update.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/google/google_update.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/DEPS View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/installer/gcapi/gcapi.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome_frame/update_launcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M google_update/google_update.gyp View 1 2 1 chunk +9 lines, -5 lines 0 comments Download
D google_update/ondemand_updates.vcproj View 1 chunk +0 lines, -65 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
Ryan Sleevi
bradn: You seem to have been the last person active, you mind going for what ...
8 years, 10 months ago (2012-02-09 04:36:03 UTC) #1
tommi (sloooow) - chröme
lgtm
8 years, 10 months ago (2012-02-09 06:42:33 UTC) #2
bradn
LGTM
8 years, 10 months ago (2012-02-09 17:56:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/9371010/2001
8 years, 10 months ago (2012-02-09 18:19:21 UTC) #4
commit-bot: I haz the power
Try job failure for 9371010-2001 (retry) on win_rel for step "update". It's a second try, ...
8 years, 10 months ago (2012-02-09 18:27:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/9371010/3003
8 years, 10 months ago (2012-02-09 18:31:58 UTC) #6
commit-bot: I haz the power
Try job failure for 9371010-3003 (retry) on linux_rel for step "check_deps". It's a second try, ...
8 years, 10 months ago (2012-02-09 19:39:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/9371010/1019
8 years, 10 months ago (2012-02-09 20:15:16 UTC) #8
commit-bot: I haz the power
Try job failure for 9371010-1019 (retry) on linux_rel for step "browser_tests". It's a second try, ...
8 years, 10 months ago (2012-02-09 21:19:17 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/9371010/1019
8 years, 10 months ago (2012-02-09 22:02:44 UTC) #10
commit-bot: I haz the power
Try job failure for 9371010-1019 (retry) on linux_rel for step "browser_tests". It's a second try, ...
8 years, 10 months ago (2012-02-09 23:26:11 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/9371010/1019
8 years, 10 months ago (2012-02-10 01:53:28 UTC) #12
commit-bot: I haz the power
Change committed as 121396
8 years, 10 months ago (2012-02-10 03:24:25 UTC) #13
Bernhard Bauer
Post-commit drive-by review! Could this have broken the Win clobber build? See http://build.chromium.org/p/chromium.lkgr/builders/Win/builds/1728/steps/compile/logs/stdio_html#browser_1: .\browser\first_run\upgrade_util_win.cc(29) : ...
8 years, 10 months ago (2012-02-13 15:18:23 UTC) #14
Ryan Sleevi
8 years, 10 months ago (2012-02-13 17:59:22 UTC) #15 
On 2012/02/13 15:18:23, Bernhard Bauer wrote:
> Post-commit drive-by review!
> 
> Could this have broken the Win clobber build?
> See
>
http://build.chromium.org/p/chromium.lkgr/builders/Win/builds/1728/steps/comp...:
> 
> 
> 
> .\browser\first_run\upgrade_util_win.cc(29) : fatal error C1083: Cannot open
> include file: 'google_update/google_update_idl.h': No such file or directory

Indeed and unfortunately. I'll send a CL to fix it up.

Powered by Google App Engine
This is Rietveld 408576698