Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 9370051: Fix pepper flash fullscreen. (Closed)

Created:
8 years, 10 months ago by ilja
Modified:
8 years, 10 months ago
Reviewers:
Wez, piman
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Fix pepper flash fullscreen. Fullscreen video was broken by http://src.chromium.org/viewvc/chrome?view=rev&revision=120490 After going fullscreen painting stopped. It seems the reason is that the change above forget hooking up DidInitiatePaint. BUG=111639 TEST=Ran youtube videos in fullsceen. Ran streetview in fullscreen. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=121498

Patch Set 1 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M content/renderer/render_widget_fullscreen_pepper.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/render_widget_fullscreen_pepper.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ilja
This is for various CrOS bugs that were filed. I verified this on 1025/R18 too ...
8 years, 10 months ago (2012-02-10 07:04:24 UTC) #1
piman
lgtm
8 years, 10 months ago (2012-02-10 07:37:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ihf@chromium.org/9370051/3001
8 years, 10 months ago (2012-02-10 18:15:19 UTC) #3
commit-bot: I haz the power
8 years, 10 months ago (2012-02-10 19:58:17 UTC) #4
Change committed as 121498

Powered by Google App Engine
This is Rietveld 408576698