Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Unified Diff: chrome/browser/webdata/web_intents_table_unittest.cc

Issue 9370043: Add default intents methods for web data service. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merge to head Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/webdata/web_intents_table_unittest.cc
diff --git a/chrome/browser/webdata/web_intents_table_unittest.cc b/chrome/browser/webdata/web_intents_table_unittest.cc
index b91317e179cfb531d2d879abac796a1b3abb9f81..d12a28577071bea3b8c10ca003f0eefff051882f 100644
--- a/chrome/browser/webdata/web_intents_table_unittest.cc
+++ b/chrome/browser/webdata/web_intents_table_unittest.cc
@@ -189,7 +189,8 @@ TEST_F(WebIntentsTableTest, DefaultServices) {
DefaultWebIntentService default_service;
default_service.action = test_action;
default_service.type = mime_image;
- default_service.url_pattern.Parse(test_url.spec());
+ ASSERT_EQ(URLPattern::PARSE_SUCCESS,
+ default_service.url_pattern.Parse(test_url.spec()));
default_service.user_date = 1;
default_service.suppression = 4;
default_service.service_url = "service_url";
@@ -209,7 +210,7 @@ TEST_F(WebIntentsTableTest, DefaultServices) {
EXPECT_EQ(test_action, defaults[0].action);
EXPECT_EQ(mime_image, defaults[0].type);
URLPattern test_pattern(URLPattern::SCHEME_HTTP, test_url.spec());
- EXPECT_EQ(test_pattern, defaults[0].url_pattern);
+ EXPECT_EQ(test_pattern.GetAsString(), defaults[0].url_pattern.GetAsString());
EXPECT_EQ(1, defaults[0].user_date);
EXPECT_EQ(4, defaults[0].suppression);
EXPECT_EQ("service_url", defaults[0].service_url);

Powered by Google App Engine
This is Rietveld 408576698