Process IDL interfaces in pre-order so that parents are seen first

client/dom/scripts/dartgenerator.py

 #!/usr/bin/python
 # Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
 """This module generates Dart APIs from the IDL database."""
 
 import emitter
 import idlnode
 import logging
@@ skipping 421 matching lines @@
       self._systems.append(html_system)
 
     if 'htmldartium' in systems:
       html_system = HtmlDartiumSystem(
           TemplateLoader(self._template_dir, ['html/dartium', 'html', '']),
           self._database, self._emitters, self._output_dir)
 
       html_system._interface_system = html_interface_system
       self._systems.append(html_system)
 
+
+    # Collect interfaces
+    interfaces = []
+    for interface in database.GetInterfaces():
+      if not _MatchSourceFilter(source_filter, interface):
+        # Skip this interface since it's not present in the required source
+        _logger.info('Omitting interface - %s' % interface.id)
+        continue
+      interfaces.append(interface)
+
     # Render all interfaces into Dart and save them in files.
-    for interface in database.GetInterfaces():
+    for interface in self._PreOrderInterfaces(interfaces):
 
       super_interface = None
       super_name = interface.id
 
-      if not _MatchSourceFilter(source_filter, interface):
-        # Skip this interface since it's not present in the required source
-        _logger.info('Omitting interface - %s' % interface.id)
-        continue
-
       if super_name in super_map:
         super_name = super_map[super_name]
 
       if (super_database is not None and
           super_database.HasInterface(super_name)):
         super_interface = super_name
 
       interface_name = interface.id
       auxiliary_file = self._auxiliary_files.get(interface_name)
       if auxiliary_file is not None:
@@ skipping 14 matching lines @@
 
     # Libraries
     if lib_dir:
       for system in self._systems:
         system.GenerateLibraries(lib_dir)
 
     for system in self._systems:
       system.Finish()
 
 
+  def _PreOrderInterfaces(self, interfaces):
+    """Returns the interfaces in pre-order, i.e. parents first."""
+    seen = set()
+    ordered = []
+    def visit(interface):
+      if interface.id in seen:
+        return
+      seen.add(interface.id)
+      for parent in interface.parents:
+        if _IsDartCollectionType(parent.type.id):
+          continue
+        if self._database.HasInterface(parent.type.id):
+          parent_interface = self._database.GetInterface(parent.type.id)
+          visit(parent_interface)
+      ordered.append(interface)
+
+    for interface in interfaces:
+      visit(interface)
+    return ordered
+
+
   def _ProcessInterface(self, interface, super_interface_name,
                         source_filter,
                         common_prefix):
     """."""
     _logger.info('Generating %s' % interface.id)
 
     generators = [system.InterfaceGenerator(interface,
                                             common_prefix,
                                             super_interface_name,
                                             source_filter)
@@ skipping 1902 matching lines @@
                    INDENT=indent,
                    NATIVENAME=native_name,
                    ARGS=argument_expressions)
 
     self._members_emitter.Emit('  $TYPE $NATIVE_NAME($PARAMS) native '
                                '"$(INTERFACE)$(NATIVE_NAME)_Callback";\n',
                                NATIVE_NAME=native_name,
                                TYPE=info.type_name,
                                PARAMS=', '.join(arg_names),
                                INTERFACE=self._interface.id)