Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Unified Diff: tools/testing/dart/test_suite.dart

Issue 9369051: Force close of browser Windows when complete. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: '' Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« tools/testing/dart/test_runner.dart ('K') | « tools/testing/dart/test_runner.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_suite.dart
===================================================================
--- tools/testing/dart/test_suite.dart (revision 4199)
+++ tools/testing/dart/test_suite.dart (working copy)
@@ -200,6 +200,11 @@
List<TestInformation> cachedTests;
final String dartDir;
Function globalTemporaryDirectory;
+ /**
+ * Reference to our test queue, so that we can notify the queue if it needs
+ * to run any cleanup after the suite completes.
+ */
+ ProcessQueue _allDoneCallbackListener;
StandardTestSuite(Map this.configuration,
String this.suiteName,
@@ -564,10 +569,22 @@
completeHandler,
expectations,
optionsFromFile['isNegative']);
+ if ((_allDoneCallbackListener != null)) {
Jennifer Messerly 2012/02/14 02:17:25 extra parens
Emily Fortuna 2012/02/14 23:55:44 Done.
+ _allDoneCallbackListener.browserUsed = configuration['browser'];
+ }
doTest(testCase);
}
}
+ /**
+ * Notify the process queue that once all the tests have completed, we need
+ * to run a process to clean up any bad state that WebDriver may have left
+ * (extra browser processes, etc).
+ */
+ void notifyIfBrowserCleanupNeeded(ProcessQueue queue) {
+ _allDoneCallbackListener = queue;
+ }
+
bool get requiresCleanTemporaryDirectory() =>
configuration['component'] == 'dartc' ||
configuration['component'] == 'chromium';
« tools/testing/dart/test_runner.dart ('K') | « tools/testing/dart/test_runner.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698