Issue 9369044: Implement elements transitions in ia32 Array constructor with n args.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9369044: Implement elements transitions in ia32 Array constructor with n args. (Closed)

Created:
8 years, 10 months ago by danno

Modified:
8 years, 10 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Implement elements transitions in ia32 Array constructor with n args. R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=10674

Patch Set 1 #

Patch Set 2 : Fixes #

Patch Set 3 : More fixes #

Total comments: 1

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -2 lines)			Patch
	M	src/ia32/builtins-ia32.cc	View	2	4 chunks	+37 lines, -2 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Yang

8 years, 10 months ago (2012-02-10 10:25:13 UTC) #3

One thing I noticed.

http://codereview.chromium.org/9369044/diff/2002/src/ia32/builtins-ia32.cc
File src/ia32/builtins-ia32.cc (right):

http://codereview.chromium.org/9369044/diff/2002/src/ia32/builtins-ia32.cc#ne...
src/ia32/builtins-ia32.cc:1281: __ RecordWriteField(ebx, HeapObject::kMapOffset,
edi, eax,
where does the value of eax come from?

Expand Messages | Collapse Messages