Issue 9369022: disable media stream creation when enable_webrtc=0

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9369022: disable media stream creation when enable_webrtc=0 (Closed)

Created:
8 years, 10 months ago by wjia(left Chromium)

Modified:
8 years, 10 months ago

Reviewers:
Satish, jam

CC:
chromium-reviews, hclam+watch_chromium.org, ddorwin+watch_chromium.org, fischman+watch_chromium.org, jam, acolwell+watch_chromium.org, annacc+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, vrk (LEFT CHROMIUM), scherkus (not reviewing), ihf+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

disable media stream creation when enable_webrtc=0 BUG=110581 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=121252

Patch Set 1 #

Total comments: 2

Patch Set 2 : code review #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -147 lines)			Patch
M	build/common.gypi	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	content/content_renderer.gypi	View		3 chunks	+1 line, -6 lines	0 comments	Download
D	content/renderer/media/media_stream_dependency_factory_stub.cc	View		1 chunk	+0 lines, -51 lines	0 comments	Download
D	content/renderer/media/media_stream_impl_stub.cc	View		1 chunk	+0 lines, -90 lines	0 comments	Download
M	content/renderer/render_view_impl.cc	View	1	4 chunks	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Satish

http://codereview.chromium.org/9369022/diff/1/content/renderer/render_view_impl.cc File content/renderer/render_view_impl.cc (right): http://codereview.chromium.org/9369022/diff/1/content/renderer/render_view_impl.cc#newcode507 content/renderer/render_view_impl.cc:507: if (!media_stream_dispatcher_) Also need to wrap these two lines ...

8 years, 10 months ago (2012-02-09 13:09:54 UTC) #3

wjia(left Chromium)

8 years, 10 months ago (2012-02-09 18:20:51 UTC) #4

http://codereview.chromium.org/9369022/diff/1/content/renderer/render_view_im...
File content/renderer/render_view_impl.cc (right):

http://codereview.chromium.org/9369022/diff/1/content/renderer/render_view_im...
content/renderer/render_view_impl.cc:507: if (!media_stream_dispatcher_)
On 2012/02/09 13:09:55, Satish wrote:
> Also need to wrap these two lines in #if defined(ENABLE_WEBRTC)

Done.

Expand Messages | Collapse Messages