First prototype of import map generator.

First prototype of import map generator.

Committed: https://code.google.com/p/dart/source/detail?r=4106

[Bob Nystrom, 2012-02-09 00:34:00]

Just to get something started in the repo.

[Jennifer Messerly, 2012-02-09 01:09:24]

lgtm

https://chromiumcodereview.appspot.com/9369006/diff/1/utils/import_mapper/imp...
File utils/import_mapper/import_mapper.dart (right):

https://chromiumcodereview.appspot.com/9369006/diff/1/utils/import_mapper/imp...
utils/import_mapper/import_mapper.dart:8:
#import('../../client/json/dart_json.dart');
heh heh :)

https://chromiumcodereview.appspot.com/9369006/diff/1/utils/import_mapper/imp...
utils/import_mapper/import_mapper.dart:68: if (definition is
DirectiveDefinition) {
perhaps:

if (definition is! DirectiveDefinition) break;

https://chromiumcodereview.appspot.com/9369006/diff/1/utils/import_mapper/imp...
utils/import_mapper/import_mapper.dart:75: // TODO(rnystrom): Should invoke the
hook again and ensure that it gets
maybe in debug mode, or something like that

[Siggi Cherem (dart-lang), 2012-02-09 01:21:57]

lgtm

https://chromiumcodereview.appspot.com/9369006/diff/1/utils/import_mapper/imp...
File utils/import_mapper/import_mapper.dart (right):

https://chromiumcodereview.appspot.com/9369006/diff/1/utils/import_mapper/imp...
utils/import_mapper/import_mapper.dart:63: final parser = new Parser(source,
true);
=> Parser(source, diet: true);

https://chromiumcodereview.appspot.com/9369006/diff/1/utils/import_mapper/imp...
utils/import_mapper/import_mapper.dart:83: // TODO(rnystrom): Hackish. How
should we handle corelib stuff?
have a map file for corelibs and import mappings from there?

[Bob Nystrom, 2012-02-09 02:05:44]

I also did the smart thing for once and added a basic unit test. Please take a
look at those changes if you don't mind.

Thanks!

https://chromiumcodereview.appspot.com/9369006/diff/1/utils/import_mapper/imp...
File utils/import_mapper/import_mapper.dart (right):

https://chromiumcodereview.appspot.com/9369006/diff/1/utils/import_mapper/imp...
utils/import_mapper/import_mapper.dart:8:
#import('../../client/json/dart_json.dart');
On 2012/02/09 01:09:24, John Messerly wrote:
> heh heh :)

:)

https://chromiumcodereview.appspot.com/9369006/diff/1/utils/import_mapper/imp...
utils/import_mapper/import_mapper.dart:63: final parser = new Parser(source,
true);
On 2012/02/09 01:21:57, sigmund wrote:
> => Parser(source, diet: true);

Done.

https://chromiumcodereview.appspot.com/9369006/diff/1/utils/import_mapper/imp...
utils/import_mapper/import_mapper.dart:68: if (definition is
DirectiveDefinition) {
On 2012/02/09 01:09:24, John Messerly wrote:
> perhaps:
> 
> if (definition is! DirectiveDefinition) break;

Done.

https://chromiumcodereview.appspot.com/9369006/diff/1/utils/import_mapper/imp...
utils/import_mapper/import_mapper.dart:75: // TODO(rnystrom): Should invoke the
hook again and ensure that it gets
On 2012/02/09 01:09:24, John Messerly wrote:
> maybe in debug mode, or something like that

Agreed.

https://chromiumcodereview.appspot.com/9369006/diff/1/utils/import_mapper/imp...
utils/import_mapper/import_mapper.dart:83: // TODO(rnystrom): Hackish. How
should we handle corelib stuff?
On 2012/02/09 01:21:57, sigmund wrote:
> have a map file for corelibs and import mappings from there?

The way this works is that the import hook *does* get a chance to handle
built-in libs. What we *don't* want to do is try to recursively walk *into*
those libs and traverse *their* imports because they may not have dart
implementations that we can parse.

[Siggi Cherem (dart-lang), 2012-02-09 02:18:23]

https://chromiumcodereview.appspot.com/9369006/diff/3001/client/testing/unitt...
File client/testing/unittest/shared.dart (right):

https://chromiumcodereview.appspot.com/9369006/diff/3001/client/testing/unitt...
client/testing/unittest/shared.dart:266: // If comparing two maps, see that
their keys and values match.
seems like you are not synced up to latest! (my changes are missing :))

https://chromiumcodereview.appspot.com/9369006/diff/3001/client/testing/unitt...
client/testing/unittest/shared.dart:267: if (_value is Map && expected is Map) {
Let's add this as mapEquals in corelib/src/expect.dart (since setEquals, etc is
there too) and add equalsMap next to equalsSet below (to be consistent)

[Bob Nystrom, 2012-02-10 00:31:47]

Adding Florian since this now has a little corelib change too...

https://chromiumcodereview.appspot.com/9369006/diff/3001/client/testing/unitt...
File client/testing/unittest/shared.dart (right):

https://chromiumcodereview.appspot.com/9369006/diff/3001/client/testing/unitt...
client/testing/unittest/shared.dart:266: // If comparing two maps, see that
their keys and values match.
On 2012/02/09 02:18:23, sigmund wrote:
> seems like you are not synced up to latest! (my changes are missing :))

Done.

https://chromiumcodereview.appspot.com/9369006/diff/3001/client/testing/unitt...
client/testing/unittest/shared.dart:267: if (_value is Map && expected is Map) {
On 2012/02/09 02:18:23, sigmund wrote:
> Let's add this as mapEquals in corelib/src/expect.dart (since setEquals, etc
is
> there too) and add equalsMap next to equalsSet below (to be consistent)

Done.

[Siggi Cherem (dart-lang), 2012-02-10 00:36:51]

lgtm

https://chromiumcodereview.appspot.com/9369006/diff/5002/client/testing/unitt...
File client/testing/unittest/shared.dart (right):

https://chromiumcodereview.appspot.com/9369006/diff/5002/client/testing/unitt...
client/testing/unittest/shared.dart:277: 
if (_value is Set ...) ?

[Bob Nystrom, 2012-02-10 00:44:18]

https://chromiumcodereview.appspot.com/9369006/diff/5002/client/testing/unitt...
File client/testing/unittest/shared.dart (right):

https://chromiumcodereview.appspot.com/9369006/diff/5002/client/testing/unitt...
client/testing/unittest/shared.dart:277: 
On 2012/02/10 00:36:51, sigmund wrote:
> if (_value is Set ...) ?

Done.

[floitsch, 2012-02-10 09:53:04]

corelib change LGTM.