Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Side by Side Diff: chrome/browser/tab_contents/spelling_menu_observer.h

Issue 9368052: Removed WebTextCheckingResult legacy API use. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed a build break on Mac. Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_TAB_CONTENTS_SPELLING_MENU_OBSERVER_H_ 5 #ifndef CHROME_BROWSER_TAB_CONTENTS_SPELLING_MENU_OBSERVER_H_
6 #define CHROME_BROWSER_TAB_CONTENTS_SPELLING_MENU_OBSERVER_H_ 6 #define CHROME_BROWSER_TAB_CONTENTS_SPELLING_MENU_OBSERVER_H_
7 #pragma once 7 #pragma once
8 8
9 #include <vector> 9 #include <vector>
10 10
11 #include "base/compiler_specific.h" 11 #include "base/compiler_specific.h"
12 #include "base/memory/scoped_ptr.h" 12 #include "base/memory/scoped_ptr.h"
13 #include "base/string16.h" 13 #include "base/string16.h"
14 #include "base/timer.h" 14 #include "base/timer.h"
15 #include "chrome/browser/tab_contents/render_view_context_menu_observer.h" 15 #include "chrome/browser/tab_contents/render_view_context_menu_observer.h"
16 16
17 class RenderViewContextMenuProxy; 17 class RenderViewContextMenuProxy;
18 class SpellCheckResult;
Hironori Bono 2012/02/16 04:22:45 nit: class -> struct.
18 class SpellingServiceClient; 19 class SpellingServiceClient;
19 20
20 namespace WebKit {
21 struct WebTextCheckingResult;
22 }
23
24 // An observer that listens to events from the RenderViewContextMenu class and 21 // An observer that listens to events from the RenderViewContextMenu class and
25 // shows suggestions from the Spelling ("do you mean") service to a context menu 22 // shows suggestions from the Spelling ("do you mean") service to a context menu
26 // while we show it. This class implements two interfaces: 23 // while we show it. This class implements two interfaces:
27 // * RenderViewContextMenuObserver 24 // * RenderViewContextMenuObserver
28 // This interface is used for adding a menu item and update it while showing. 25 // This interface is used for adding a menu item and update it while showing.
29 // * content::URLFetcherDelegate 26 // * content::URLFetcherDelegate
30 // This interface is used for sending a JSON_RPC request to the Spelling 27 // This interface is used for sending a JSON_RPC request to the Spelling
31 // service and retrieving its response. 28 // service and retrieving its response.
32 // These interfaces allow this class to make a JSON-RPC call to the Spelling 29 // These interfaces allow this class to make a JSON-RPC call to the Spelling
33 // service in the background and update the context menu while showing. The 30 // service in the background and update the context menu while showing. The
(...skipping 14 matching lines...) Expand all
48 // RenderViewContextMenuObserver implementation. 45 // RenderViewContextMenuObserver implementation.
49 virtual void InitMenu(const content::ContextMenuParams& params) OVERRIDE; 46 virtual void InitMenu(const content::ContextMenuParams& params) OVERRIDE;
50 virtual bool IsCommandIdSupported(int command_id) OVERRIDE; 47 virtual bool IsCommandIdSupported(int command_id) OVERRIDE;
51 virtual bool IsCommandIdEnabled(int command_id) OVERRIDE; 48 virtual bool IsCommandIdEnabled(int command_id) OVERRIDE;
52 virtual void ExecuteCommand(int command_id) OVERRIDE; 49 virtual void ExecuteCommand(int command_id) OVERRIDE;
53 50
54 // A callback function called when the Spelling service finishes checking a 51 // A callback function called when the Spelling service finishes checking a
55 // misspelled word. 52 // misspelled word.
56 void OnTextCheckComplete( 53 void OnTextCheckComplete(
57 int tag, 54 int tag,
58 const std::vector<WebKit::WebTextCheckingResult>& results); 55 const std::vector<SpellCheckResult>& results);
59 56
60 private: 57 private:
61 // The callback function for base::RepeatingTimer<SpellingMenuClient>. This 58 // The callback function for base::RepeatingTimer<SpellingMenuClient>. This
62 // function updates the "loading..." animation in the context-menu item. 59 // function updates the "loading..." animation in the context-menu item.
63 void OnAnimationTimerExpired(); 60 void OnAnimationTimerExpired();
64 61
65 // The interface to add a context-menu item and update it. This class uses 62 // The interface to add a context-menu item and update it. This class uses
66 // this interface to avoid accesing context-menu items directly. 63 // this interface to avoid accesing context-menu items directly.
67 RenderViewContextMenuProxy* proxy_; 64 RenderViewContextMenuProxy* proxy_;
68 65
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
103 100
104 // Flag indicating whether online spelling correction service is enabled. When 101 // Flag indicating whether online spelling correction service is enabled. When
105 // this variable is true and we right-click a misspelled word, we send a 102 // this variable is true and we right-click a misspelled word, we send a
106 // JSON-RPC request to the service and retrieve suggestions. 103 // JSON-RPC request to the service and retrieve suggestions.
107 bool integrate_spelling_service_; 104 bool integrate_spelling_service_;
108 105
109 DISALLOW_COPY_AND_ASSIGN(SpellingMenuObserver); 106 DISALLOW_COPY_AND_ASSIGN(SpellingMenuObserver);
110 }; 107 };
111 108
112 #endif // CHROME_BROWSER_TAB_CONTENTS_SPELLING_MENU_OBSERVER_H_ 109 #endif // CHROME_BROWSER_TAB_CONTENTS_SPELLING_MENU_OBSERVER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698