runtime/vm/gc_marker.cc - Issue 9368049: Add external byte array API and finalize external strings and byte arrays.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/gc_marker.cc

Issue 9368049: Add external byte array API and finalize external strings and byte arrays. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: address review comments Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/gc_marker.cc

diff --git a/runtime/vm/gc_marker.cc b/runtime/vm/gc_marker.cc

index ff66ca03b25527fdabb541313f046f50acf68075..2c8c9f2fb73a2b3ca036b0790808b1109efa94f0 100644

--- a/runtime/vm/gc_marker.cc

+++ b/runtime/vm/gc_marker.cc

@@ -199,7 +199,7 @@ class MarkingWeakVisitor : public HandleVisitor {

RawObject* raw_obj = handle->raw();

ASSERT(raw_obj->IsHeapObject());

if (!raw_obj->IsMarked() && raw_obj->IsOldObject()) {

- handle->Finalize();

+ WeakPersistentHandle::Finalize(handle);

}

« no previous file with comments | « runtime/vm/dart_api_state.h ('k') | runtime/vm/object.h » ('j') | no next file with comments »