Add external byte array API and finalize external strings and byte arrays.

runtime/vm/raw_object_snapshot.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/bigint_operations.h"
 #include "vm/object.h"
 #include "vm/object_store.h"
 #include "vm/snapshot.h"
 #include "vm/visitor.h"
 
@@ skipping 1461 matching lines @@
                                        intptr_t object_id,
                                        Snapshot::Kind kind) {
   // Serialize as a non-external one byte string.
   StringWriteTo(writer,
                 object_id,
                 kind,
                 ObjectStore::kOneByteStringClass,
                 ptr()->tags_,
                 ptr()->length_,
                 ptr()->hash_,
-                ptr()->external_data_->data_);
+                ptr()->external_data_->data());
 }
 
 
 void RawExternalTwoByteString::WriteTo(SnapshotWriter* writer,
                                        intptr_t object_id,
                                        Snapshot::Kind kind) {
   // Serialize as a non-external two byte string.
   StringWriteTo(writer,
                 object_id,
                 kind,
                 ObjectStore::kTwoByteStringClass,
                 ptr()->tags_,
                 ptr()->length_,
                 ptr()->hash_,
-                ptr()->external_data_->data_);
+                ptr()->external_data_->data());
 }
 
 
 void RawExternalFourByteString::WriteTo(SnapshotWriter* writer,
                                         intptr_t object_id,
                                         Snapshot::Kind kind) {
   // Serialize as a non-external four byte string.
   StringWriteTo(writer,
                 object_id,
                 kind,
                 ObjectStore::kFourByteStringClass,
                 ptr()->tags_,
                 ptr()->length_,
                 ptr()->hash_,
-                ptr()->external_data_->data_);
+                ptr()->external_data_->data());
 }
 
 
 RawBool* Bool::ReadFrom(SnapshotReader* reader,
                         intptr_t object_id,
                         intptr_t tags,
                         Snapshot::Kind kind) {
   UNREACHABLE();
   return Bool::null();
 }
@@ skipping 208 matching lines @@
 void RawExternalByteArray::WriteTo(SnapshotWriter* writer,
                                    intptr_t object_id,
                                    Snapshot::Kind kind) {
   // Serialize as an internal byte array.
   ByteArrayWriteTo(writer,
                    object_id,
                    kind,
                    ObjectStore::kInternalByteArrayClass,
                    ptr()->tags_,
                    ptr()->length_,
-                   ptr()->data_);
+                   ptr()->external_data_->data());
 }
 
 
 RawClosure* Closure::ReadFrom(SnapshotReader* reader,
                               intptr_t object_id,
                               intptr_t tags,
                               Snapshot::Kind kind) {
   UNIMPLEMENTED();
   return Closure::null();
 }
@@ skipping 72 matching lines @@
   // Write out all the other fields.
   writer->Write<RawObject*>(ptr()->num_bracket_expressions_);
   writer->WriteObject(ptr()->pattern_);
   writer->WriteIntptrValue(ptr()->type_);
   writer->WriteIntptrValue(ptr()->flags_);
 
   // Do not write out the data part which is native.
 }
 
 }  // namespace dart