Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Side by Side Diff: tools/testing/dart/test_suite.dart

Issue 9368008: Additional flakiness reducing changes. Also rerun DRT on false positive tests. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: '' Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 /** 5 /**
6 * Classes and methods for enumerating and preparing tests. 6 * Classes and methods for enumerating and preparing tests.
7 * 7 *
8 * This library includes: 8 * This library includes:
9 * 9 *
10 * - Creating tests by listing all the Dart files in certain directories, 10 * - Creating tests by listing all the Dart files in certain directories,
(...skipping 477 matching lines...) Expand 10 before | Expand all | Expand 10 after
488 if (new Platform().operatingSystem() == 'windows') { 488 if (new Platform().operatingSystem() == 'windows') {
489 // Firefox on Windows does not like absolute file path names that start 489 // Firefox on Windows does not like absolute file path names that start
490 // with 'C:' adding 'file:///' solves the problem. 490 // with 'C:' adding 'file:///' solves the problem.
491 filePrefix = 'file:///'; 491 filePrefix = 'file:///';
492 } 492 }
493 htmlTest.writeStringSync(GetHtmlContents( 493 htmlTest.writeStringSync(GetHtmlContents(
494 filename, 494 filename,
495 '$filePrefix$dartDir/client/testing/unittest/test_controller.js', 495 '$filePrefix$dartDir/client/testing/unittest/test_controller.js',
496 scriptType, 496 scriptType,
497 filePrefix + scriptPath)); 497 filePrefix + scriptPath));
498 htmlTest.flushSync();
499 htmlTest.closeSync(); 498 htmlTest.closeSync();
500 499
501 List<String> compilerArgs = TestUtils.standardOptions(configuration); 500 List<String> compilerArgs = TestUtils.standardOptions(configuration);
502 String compilerExecutable = TestUtils.compilerPath(configuration); 501 String compilerExecutable = TestUtils.compilerPath(configuration);
503 switch (component) { 502 switch (component) {
504 case 'chromium': 503 case 'chromium':
505 compilerArgs.addAll(['--work', tempDir.path]); 504 compilerArgs.addAll(['--work', tempDir.path]);
506 compilerArgs.addAll(vmOptions); 505 compilerArgs.addAll(vmOptions);
507 compilerArgs.add('--ignore-unrecognized-flags'); 506 compilerArgs.add('--ignore-unrecognized-flags');
508 // TODO(zundel): remove assumption of generated code from dartc 507 // TODO(zundel): remove assumption of generated code from dartc
(...skipping 615 matching lines...) Expand 10 before | Expand all | Expand 10 after
1124 * $noCrash tests are expected to be flaky but not crash 1123 * $noCrash tests are expected to be flaky but not crash
1125 * $pass tests are expected to pass 1124 * $pass tests are expected to pass
1126 * $failOk tests are expected to fail that we won't fix 1125 * $failOk tests are expected to fail that we won't fix
1127 * $fail tests are expected to fail that we should fix 1126 * $fail tests are expected to fail that we should fix
1128 * $crash tests are expected to crash that we should fix 1127 * $crash tests are expected to crash that we should fix
1129 * $timeout tests are allowed to timeout 1128 * $timeout tests are allowed to timeout
1130 """; 1129 """;
1131 print(report); 1130 print(report);
1132 } 1131 }
1133 } 1132 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698