Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4488)

Unified Diff: chrome/browser/importer/safari_importer.mm

Issue 9365030: More SQL statement usage regularization. Back-touch some (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix log messages Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/importer/safari_importer.mm
diff --git a/chrome/browser/importer/safari_importer.mm b/chrome/browser/importer/safari_importer.mm
index 095fa54a93c39927d64db24765db8d39e1dae3e2..fedd2f3a83038947f2c5db1b96a35afdd3295039 100644
--- a/chrome/browser/importer/safari_importer.mm
+++ b/chrome/browser/importer/safari_importer.mm
@@ -142,8 +142,6 @@ void SafariImporter::ImportFaviconURLs(sql::Connection* db,
FaviconMap* favicon_map) {
const char* query = "SELECT iconID, url FROM PageURL;";
sql::Statement s(db->GetUniqueStatement(query));
- if (!s)
- return;
while (s.Step() && !cancelled()) {
int64 icon_id = s.ColumnInt64(0);
@@ -161,8 +159,6 @@ void SafariImporter::LoadFaviconData(
"ON i.iconID = d.iconID "
"WHERE i.iconID = ?;";
sql::Statement s(db->GetUniqueStatement(query));
- if (!s)
- return;
for (FaviconMap::const_iterator i = favicon_map.begin();
i != favicon_map.end(); ++i) {

Powered by Google App Engine
This is Rietveld 408576698