Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1672)

Unified Diff: chrome/browser/net/sqlite_persistent_cookie_store.cc

Issue 9365030: More SQL statement usage regularization. Back-touch some (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merge to head Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/net/sqlite_persistent_cookie_store.cc
diff --git a/chrome/browser/net/sqlite_persistent_cookie_store.cc b/chrome/browser/net/sqlite_persistent_cookie_store.cc
index 474be403ef5a76c76a78b7cae9096af54cdb7702..1bde1b7996d3528100dccac2852f7fdb39db8457 100644
--- a/chrome/browser/net/sqlite_persistent_cookie_store.cc
+++ b/chrome/browser/net/sqlite_persistent_cookie_store.cc
@@ -506,8 +506,7 @@ bool SQLitePersistentCookieStore::Backend::InitializeDatabase() {
sql::Statement smt(db_->GetUniqueStatement(
"SELECT DISTINCT host_key FROM cookies"));
- if (!smt) {
- NOTREACHED() << "select statement prep failed";
+ if (!smt.is_valid()) {
db_.reset();
return false;
}
@@ -590,7 +589,6 @@ bool SQLitePersistentCookieStore::Backend::LoadCookiesForDomains(
"FROM cookies WHERE host_key = ? AND persistent = 1"));
}
if (!smt.is_valid()) {
- NOTREACHED() << "select statement prep failed";
smt.Clear(); // Disconnect smt_ref from db_.
db_.reset();
return false;
@@ -793,30 +791,23 @@ void SQLitePersistentCookieStore::Backend::Commit() {
"expires_utc, secure, httponly, last_access_utc, has_expires, "
"persistent) "
"VALUES (?,?,?,?,?,?,?,?,?,?,?)"));
- if (!add_smt) {
- NOTREACHED();
+ if (!add_smt.is_valid())
return;
- }
sql::Statement update_access_smt(db_->GetCachedStatement(SQL_FROM_HERE,
"UPDATE cookies SET last_access_utc=? WHERE creation_utc=?"));
- if (!update_access_smt) {
- NOTREACHED();
+ if (!update_access_smt.is_valid())
return;
- }
sql::Statement del_smt(db_->GetCachedStatement(SQL_FROM_HERE,
"DELETE FROM cookies WHERE creation_utc=?"));
- if (!del_smt) {
- NOTREACHED();
+ if (!del_smt.is_valid())
return;
- }
sql::Transaction transaction(db_.get());
- if (!transaction.Begin()) {
- NOTREACHED();
+ if (!transaction.Begin())
return;
- }
+
for (PendingOperationsList::iterator it = ops.begin();
it != ops.end(); ++it) {
// Free the cookies as we commit them to the database.
« no previous file with comments | « chrome/browser/net/sqlite_origin_bound_cert_store.cc ('k') | chrome/browser/password_manager/login_database.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698