chrome/browser/diagnostics/sqlite_diagnostics.cc - Issue 9365030: More SQL statement usage regularization. Back-touch some

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/diagnostics/sqlite_diagnostics.cc

Issue 9365030: More SQL statement usage regularization. Back-touch some (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Merge to head Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/diagnostics/sqlite_diagnostics.cc

diff --git a/chrome/browser/diagnostics/sqlite_diagnostics.cc b/chrome/browser/diagnostics/sqlite_diagnostics.cc

index 1e58591275c2da4ec5b4fcbb08c9ea1d2cc2345a..7f2e6f5ba63314bec86afdf31ff49d34c5ef2cf0 100644

--- a/chrome/browser/diagnostics/sqlite_diagnostics.cc

+++ b/chrome/browser/diagnostics/sqlite_diagnostics.cc

@@ -54,7 +54,7 @@ class SqliteIntegrityTest : public DiagnosticTest {

return true;

}

sql::Statement s(db.GetUniqueStatement("PRAGMA integrity_check;"));

- if (!s) {

+ if (!s.is_valid()) {

int error = db.GetErrorCode();

if (SQLITE_BUSY == error) {

RecordFailure(ASCIIToUTF16("DB locked by another process"));