Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Unified Diff: webkit/database/databases_table.cc

Issue 9365030: More SQL statement usage regularization. Back-touch some (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/database/databases_table.cc
diff --git a/webkit/database/databases_table.cc b/webkit/database/databases_table.cc
index 765be53f174c77b99b5d564a931a6e77e9031e78..ed4b6eee13bf870b7927af5d5d490eef1e599919 100644
--- a/webkit/database/databases_table.cc
+++ b/webkit/database/databases_table.cc
@@ -80,6 +80,7 @@ bool DatabasesTable::InsertDatabaseDetails(const DatabaseDetails& details) {
insert_statement.BindString16(1, details.database_name);
insert_statement.BindString16(2, details.description);
insert_statement.BindInt64(3, details.estimated_size);
+
return insert_statement.Run();
}
@@ -91,6 +92,7 @@ bool DatabasesTable::UpdateDatabaseDetails(const DatabaseDetails& details) {
update_statement.BindInt64(1, details.estimated_size);
update_statement.BindString16(2, details.origin_identifier);
update_statement.BindString16(3, details.database_name);
+
return (update_statement.Run() && db_->GetLastChangeCount());
}
@@ -100,6 +102,7 @@ bool DatabasesTable::DeleteDatabaseDetails(const string16& origin_identifier,
SQL_FROM_HERE, "DELETE FROM Databases WHERE origin = ? AND name = ?"));
delete_statement.BindString16(0, origin_identifier);
delete_statement.BindString16(1, database_name);
+
return (delete_statement.Run() && db_->GetLastChangeCount());
}
@@ -137,6 +140,7 @@ bool DatabasesTable::DeleteOrigin(const string16& origin_identifier) {
sql::Statement delete_statement(db_->GetCachedStatement(
SQL_FROM_HERE, "DELETE FROM Databases WHERE origin = ?"));
delete_statement.BindString16(0, origin_identifier);
+
return (delete_statement.Run() && db_->GetLastChangeCount());
}

Powered by Google App Engine
This is Rietveld 408576698