More SQL statement usage regularization. Back-touch some

webkit/database/databases_table.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "webkit/database/databases_table.h"
 
 #include "base/logging.h"
 #include "base/utf_string_conversions.h"
 #include "sql/statement.h"
 
@@ skipping 62 matching lines @@
 }
 
 bool DatabasesTable::InsertDatabaseDetails(const DatabaseDetails& details) {
   sql::Statement insert_statement(db_->GetCachedStatement(
       SQL_FROM_HERE, "INSERT INTO Databases (origin, name, description, "
                      "estimated_size) VALUES (?, ?, ?, ?)"));
   insert_statement.BindString16(0, details.origin_identifier);
   insert_statement.BindString16(1, details.database_name);
   insert_statement.BindString16(2, details.description);
   insert_statement.BindInt64(3, details.estimated_size);
+

[Scott Hess - ex-Googler, 2012/02/13 22:04:04]

Egregious whitespace changes are egregious.  I'd remove this file unless you
originated the formatting you're changing.

[Greg Billock, 2012/02/13 22:48:59]

I've been using this formatting everywhere else. I just missed this spot. Part
of my intent is to make all the usages of the API look stylistically very
uniform. Part of that is emphasizing the "paragraph" of creating the statement
and binding to it. That'll be more concrete once we have the bind order
enforcement, too.

[Scott Hess - ex-Googler, 2012/02/13 22:52:58]

OK.  I do kind of think that's tilting against windmills, though...

   return insert_statement.Run();
 }
 
 bool DatabasesTable::UpdateDatabaseDetails(const DatabaseDetails& details) {
   sql::Statement update_statement(db_->GetCachedStatement(
       SQL_FROM_HERE, "UPDATE Databases SET description = ?, "
                      "estimated_size = ? WHERE origin = ? AND name = ?"));
   update_statement.BindString16(0, details.description);
   update_statement.BindInt64(1, details.estimated_size);
   update_statement.BindString16(2, details.origin_identifier);
   update_statement.BindString16(3, details.database_name);
+
   return (update_statement.Run() && db_->GetLastChangeCount());
 }
 
 bool DatabasesTable::DeleteDatabaseDetails(const string16& origin_identifier,
                                            const string16& database_name) {
   sql::Statement delete_statement(db_->GetCachedStatement(
       SQL_FROM_HERE, "DELETE FROM Databases WHERE origin = ? AND name = ?"));
   delete_statement.BindString16(0, origin_identifier);
   delete_statement.BindString16(1, database_name);
+
   return (delete_statement.Run() && db_->GetLastChangeCount());
 }
 
 bool DatabasesTable::GetAllOrigins(std::vector<string16>* origins) {
   sql::Statement statement(db_->GetCachedStatement(
       SQL_FROM_HERE, "SELECT DISTINCT origin FROM Databases ORDER BY origin"));
 
   while (statement.Step())
     origins->push_back(statement.ColumnString16(0));
 
@@ skipping 17 matching lines @@
     details_vector->push_back(details);
   }
 
   return statement.Succeeded();
 }
 
 bool DatabasesTable::DeleteOrigin(const string16& origin_identifier) {
   sql::Statement delete_statement(db_->GetCachedStatement(
       SQL_FROM_HERE, "DELETE FROM Databases WHERE origin = ?"));
   delete_statement.BindString16(0, origin_identifier);
+
   return (delete_statement.Run() && db_->GetLastChangeCount());
 }
 
 }  // namespace webkit_database