Issue 9365023: add string-equals to unittest, fix implementation in expect.dart

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9365023: add string-equals to unittest, fix implementation in expect.dart (Closed)

Created:
8 years, 10 months ago by Siggi Cherem (dart-lang)

Modified:
8 years, 10 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

add string-equals to unittest, fix implementation in expect.dart Committed: https://code.google.com/p/dart/source/detail?r=4050

Patch Set 2 : '' #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -2 lines)			Patch
	M	client/testing/unittest/shared.dart	View	1	1 chunk	+5 lines, -1 line	0 comments	Download
	M	corelib/src/expect.dart	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

https://chromiumcodereview.appspot.com/9365023/diff/1/client/testing/unittest/shared.dart File client/testing/unittest/shared.dart (right): https://chromiumcodereview.appspot.com/9365023/diff/1/client/testing/unittest/shared.dart#newcode316 client/testing/unittest/shared.dart:316: void equalsString(String expected) { Why don't we just make ...

8 years, 10 months ago (2012-02-08 19:17:43 UTC) #2

Siggi Cherem (dart-lang)

8 years, 10 months ago (2012-02-08 19:23:51 UTC) #3

LGTM!

Expand Messages | Collapse Messages

Issue 9365023: add string-equals to unittest, fix implementation in expect.dart (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages