Issue 9365020: Convert fast smi-only to fast object in generated code for array push.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9365020: Convert fast smi-only to fast object in generated code for array push. (Closed)

Created:
8 years, 10 months ago by Yang

Modified:
8 years, 10 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Convert fast smi-only to fast object in generated code for array push. Committed: https://code.google.com/p/v8/source/detail?r=10648

Patch Set 1 #

Total comments: 4

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+131 lines, -66 lines)			Patch
M	src/arm/stub-cache-arm.cc	View	3 chunks	+42 lines, -20 lines	1 comment	Download
M	src/ia32/stub-cache-ia32.cc	View	7 chunks	+45 lines, -23 lines	2 comments	Download
M	src/x64/stub-cache-x64.cc	View	6 chunks	+44 lines, -23 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

8 years, 10 months ago (2012-02-08 16:24:55 UTC) #2

LGTM with nits.

I think we can increase readability a bit by changing some of the comments, as
noted for ia32. The same suggestions apply to the other architectures, which
have identical comments.

https://chromiumcodereview.appspot.com/9365020/diff/1/src/arm/stub-cache-arm.cc
File src/arm/stub-cache-arm.cc (right):

https://chromiumcodereview.appspot.com/9365020/diff/1/src/arm/stub-cache-arm....
src/arm/stub-cache-arm.cc:1547: __ mov(r2, r1);
nit: s/r1/receiver/

https://chromiumcodereview.appspot.com/9365020/diff/1/src/ia32/stub-cache-ia3...
File src/ia32/stub-cache-ia32.cc (right):

https://chromiumcodereview.appspot.com/9365020/diff/1/src/ia32/stub-cache-ia3...
src/ia32/stub-cache-ia32.cc:1365: // Get the element's length into ecx.
s/element's/elements'/

https://chromiumcodereview.appspot.com/9365020/diff/1/src/ia32/stub-cache-ia3...
src/ia32/stub-cache-ia32.cc:1379: // Push the element.
Maybe "Store the value"? or "Push the new element"? (cf. "Check if value is a
smi" above.)

https://chromiumcodereview.appspot.com/9365020/diff/1/src/x64/stub-cache-x64.cc
File src/x64/stub-cache-x64.cc (right):

https://chromiumcodereview.appspot.com/9365020/diff/1/src/x64/stub-cache-x64....
src/x64/stub-cache-x64.cc:1366: rax, times_pointer_size,
nit: I'd align this under "rdi".

Expand Messages | Collapse Messages