Exposed Listen and Accept methods to Native Client.

Exposed PPB_TCPServerSocket_Private interface from renderer process to Native Client.

BUG=108277
TEST=UI test TestTCPServerSocketPrivate

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=123719

[ygorshenin1, 2012-02-14 10:31:54]

This CL continues http://codereview.chromium.org/9283022/ and together they
expose Server Sockets to Native Client.

[ygorshenin1, 2012-02-22 12:42:10]

Friendly ping.

[bbudge, 2012-02-22 13:46:21]

On 2012/02/22 12:42:10, ygorshenin1 wrote:
> Friendly ping.

I wasn't sure if you wanted a review, since the tries didn't compile.

[ygorshenin1, 2012-02-22 19:24:14]

On 2012/02/22 13:46:21, bbudge1 wrote:
> On 2012/02/22 12:42:10, ygorshenin1 wrote:
> > Friendly ping.
> 
> I wasn't sure if you wanted a review, since the tries didn't compile.

Sorry If I mislead you ---  as you can see, last patch is successfully compiled.
And I need a review because CL http://codereview.chromium.org/9283022/ is
commited.

[bbudge, 2012-02-22 20:54:54]

LGTM w/nits

http://codereview.chromium.org/9365016/diff/13001/ppapi/c/private/ppb_tcp_ser...
File ppapi/c/private/ppb_tcp_server_socket_private.h (right):

http://codereview.chromium.org/9365016/diff/13001/ppapi/c/private/ppb_tcp_ser...
ppapi/c/private/ppb_tcp_server_socket_private.h:7: *   modified Tue Feb 14
14:03:37 2012.
You can leave this file out of CL. The generator tool shouldn't modify the file
if only timestamp changes.

http://codereview.chromium.org/9365016/diff/13001/ppapi/native_client/src/sha...
File
ppapi/native_client/src/shared/ppapi_proxy/ppb_tcp_server_socket_private.srpc
(right):

http://codereview.chromium.org/9365016/diff/13001/ppapi/native_client/src/sha...
ppapi/native_client/src/shared/ppapi_proxy/ppb_tcp_server_socket_private.srpc:13:
'inputs': [['instance', 'PP_Instance'],            # PP_Instance
nit: These comments are mostly useful when the type isn't obvious from the
parameter definition. I omit them otherwise.

[ygorshenin1, 2012-02-24 08:14:57]

Thanks!

http://codereview.chromium.org/9365016/diff/13001/ppapi/c/private/ppb_tcp_ser...
File ppapi/c/private/ppb_tcp_server_socket_private.h (right):

http://codereview.chromium.org/9365016/diff/13001/ppapi/c/private/ppb_tcp_ser...
ppapi/c/private/ppb_tcp_server_socket_private.h:7: *   modified Tue Feb 14
14:03:37 2012.
On 2012/02/22 20:54:54, bbudge1 wrote:
> You can leave this file out of CL. The generator tool shouldn't modify the
file
> if only timestamp changes.

Done.

http://codereview.chromium.org/9365016/diff/13001/ppapi/native_client/src/sha...
File
ppapi/native_client/src/shared/ppapi_proxy/ppb_tcp_server_socket_private.srpc
(right):

http://codereview.chromium.org/9365016/diff/13001/ppapi/native_client/src/sha...
ppapi/native_client/src/shared/ppapi_proxy/ppb_tcp_server_socket_private.srpc:13:
'inputs': [['instance', 'PP_Instance'],            # PP_Instance
On 2012/02/22 20:54:54, bbudge1 wrote:
> nit: These comments are mostly useful when the type isn't obvious from the
> parameter definition. I omit them otherwise.

Done.

[commit-bot: I haz the power, 2012-02-24 08:15:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ygorshenin@chromium.org/9365016/19001

[commit-bot: I haz the power, 2012-02-24 08:15:38]

Presubmit check for 9365016-19001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Warnings **
Found lines longer than 80 characters (first 5 shown).
  ppapi/native_client/src/shared/ppapi_proxy/ppb_rpc_client.cc, line 2493, 85
chars \
  ppapi/native_client/src/shared/ppapi_proxy/ppb_rpc_client.cc, line 2510, 96
chars \
  ppapi/native_client/src/shared/ppapi_proxy/ppb_rpc_client.cc, line 2527, 85
chars \
  ppapi/native_client/src/shared/ppapi_proxy/ppb_rpc_client.cc, line 2550, 85
chars \
  ppapi/native_client/src/shared/ppapi_proxy/ppb_rpc_client.cc, line 2571, 92
chars

Presubmit checks took 2.0s to calculate.

[jvoung - send to chromium..., 2012-02-27 18:42:19]

http://codereview.chromium.org/9365016/diff/19001/ppapi/native_client/src/sha...
File
ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_tcp_server_socket_private_rpc_server.cc
(right):

http://codereview.chromium.org/9365016/diff/19001/ppapi/native_client/src/sha...
ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_tcp_server_socket_private_rpc_server.cc:28:
return static_cast<nacl_abi_size_t>(sizeof(PP_Resource));
Does the ppapi_proxy code use UNREFERENCED_PARAMETER?

I was trying to do a DEPS bump and saw:
http://build.chromium.org/p/tryserver.nacl/builders/nacl-lucid64_glibc_opt/bu...


cc1plus: warnings being treated as errors
/mnt/data/build/slave/nacl-lucid64_glibc_opt/build/ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_tcp_server_socket_private_rpc_server.cc:27:error:
unused parameter 'result'