Inline builtin Math functions functions in more cases.

Inline builtin Math functions functions in more cases.

Until now we only could inline as specialized HIR instructions when called
as a method (e.g. Math.abs)

It is very common practice to abbreviate calls to those functions by defining
a global or local variable like:

var a = Math.abs;
var x = a(123);

This change allows inlining them when called as a function (global or local).
Committed: https://code.google.com/p/v8/source/detail?r=10640

[Vyacheslav Egorov (Chromium), 2012-02-08 10:50:59]

lgtm

https://chromiumcodereview.appspot.com/9365013/diff/3002/src/hydrogen.cc
File src/hydrogen.cc (right):

https://chromiumcodereview.appspot.com/9365013/diff/3002/src/hydrogen.cc#newc...
src/hydrogen.cc:5061: bool HGraphBuilder::TryInlineBuiltinFunctionCall(Call*
expr, bool drop_extra) {
maybe it's time to have enum for drop_extra so it would be easier to read call
sites.

https://chromiumcodereview.appspot.com/9365013/diff/3002/src/hydrogen.cc#newc...
src/hydrogen.cc:5073: if (argument_count == 2) {
I think you can just use expr->arguments()->length() == 1 here.

https://chromiumcodereview.appspot.com/9365013/diff/3002/src/hydrogen.cc#newc...
src/hydrogen.cc:5080: if (drop_extra) Drop(1);  // Optionally drop the function.
It would be good to add test case that ensures that we deopt from inside
LUnaryMathOperation with correct environment.

[fschneider, 2012-02-08 11:45:17]

https://chromiumcodereview.appspot.com/9365013/diff/3002/src/hydrogen.cc
File src/hydrogen.cc (right):

https://chromiumcodereview.appspot.com/9365013/diff/3002/src/hydrogen.cc#newc...
src/hydrogen.cc:5073: if (argument_count == 2) {
On 2012/02/08 10:50:59, Vyacheslav Egorov wrote:
> I think you can just use expr->arguments()->length() == 1 here.

Done.

https://chromiumcodereview.appspot.com/9365013/diff/3002/src/hydrogen.cc#newc...
src/hydrogen.cc:5080: if (drop_extra) Drop(1);  // Optionally drop the function.
On 2012/02/08 10:50:59, Vyacheslav Egorov wrote:
> It would be good to add test case that ensures that we deopt from inside
> LUnaryMathOperation with correct environment.

Done.