Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9363045: Revert 121920 - dbus: add ObjectPath type (Closed)

Created:
8 years, 10 months ago by dpapad
Modified:
8 years, 10 months ago
Reviewers:
keybuk
CC:
chromium-reviews, cbentzel+watch_chromium.org, nkostylev+watch_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Revert 121920 - dbus: add ObjectPath type Rather than use std::string for object paths, add a dbus::ObjectPath type that wraps one while allowing more type-safety. This solves all sorts of issues with confusing object paths for strings, and allows us to do Properties code using templates disambiguating them from strings. BUG=chromium:109194 TEST=built and run tests Change-Id: Icaf6f19daea4af23a9d2ec0ed76d2cbd379d680e Review URL: http://codereview.chromium.org/9378039 TBR=keybuk@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=121923

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+333 lines, -470 lines) Patch
M chrome/browser/chromeos/bluetooth/bluetooth_adapter.cc View 2 chunks +17 lines, -17 lines 0 comments Download
M chrome/browser/chromeos/bluetooth/bluetooth_manager.cc View 6 chunks +12 lines, -15 lines 0 comments Download
M chrome/browser/chromeos/dbus/bluetooth_adapter_client.h View 3 chunks +9 lines, -10 lines 0 comments Download
M chrome/browser/chromeos/dbus/bluetooth_adapter_client.cc View 9 chunks +73 lines, -81 lines 0 comments Download
M chrome/browser/chromeos/dbus/bluetooth_device_client.cc View 4 chunks +11 lines, -13 lines 0 comments Download
M chrome/browser/chromeos/dbus/bluetooth_manager_client.h View 3 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/dbus/bluetooth_manager_client.cc View 6 chunks +15 lines, -16 lines 0 comments Download
M chrome/browser/chromeos/dbus/cros_dbus_service.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/dbus/cros_dbus_service_unittest.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/dbus/cros_disks_client.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/dbus/image_burner_client.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/dbus/mock_bluetooth_adapter_client.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/dbus/power_manager_client.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/dbus/proxy_resolution_service_provider_unittest.cc View 4 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/dbus/sensors_client.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/dbus/session_manager_client.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/dbus/speech_synthesizer_client.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/dbus/update_engine_client.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/password_manager/native_backend_kwallet_x.cc View 3 chunks +2 lines, -5 lines 0 comments Download
M chrome/browser/password_manager/native_backend_kwallet_x_unittest.cc View 4 chunks +4 lines, -5 lines 0 comments Download
M content/browser/geolocation/wifi_data_provider_linux.cc View 15 chunks +28 lines, -31 lines 0 comments Download
M content/browser/geolocation/wifi_data_provider_linux_unittest.cc View 8 chunks +15 lines, -20 lines 0 comments Download
M content/browser/power_save_blocker_linux.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M dbus/bus.h View 7 chunks +7 lines, -8 lines 0 comments Download
M dbus/bus.cc View 6 chunks +11 lines, -13 lines 0 comments Download
M dbus/bus_unittest.cc View 6 chunks +11 lines, -14 lines 0 comments Download
M dbus/dbus.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M dbus/end_to_end_async_unittest.cc View 3 chunks +3 lines, -5 lines 0 comments Download
M dbus/end_to_end_sync_unittest.cc View 3 chunks +3 lines, -5 lines 0 comments Download
M dbus/exported_object.h View 4 chunks +3 lines, -4 lines 0 comments Download
M dbus/exported_object.cc View 4 chunks +4 lines, -5 lines 0 comments Download
M dbus/message.h View 9 chunks +8 lines, -9 lines 0 comments Download
M dbus/message.cc View 11 chunks +18 lines, -19 lines 0 comments Download
M dbus/message_unittest.cc View 13 chunks +19 lines, -20 lines 0 comments Download
M dbus/mock_bus.h View 3 chunks +5 lines, -6 lines 0 comments Download
M dbus/mock_exported_object.h View 3 chunks +2 lines, -3 lines 0 comments Download
M dbus/mock_exported_object.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M dbus/mock_object_proxy.h View 3 chunks +2 lines, -3 lines 0 comments Download
M dbus/mock_object_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M dbus/mock_unittest.cc View 6 chunks +8 lines, -11 lines 0 comments Download
D dbus/object_path.h View 1 chunk +0 lines, -46 lines 0 comments Download
D dbus/object_path.cc View 1 chunk +0 lines, -21 lines 0 comments Download
M dbus/object_proxy.h View 3 chunks +2 lines, -3 lines 0 comments Download
M dbus/object_proxy.cc View 2 chunks +1 line, -2 lines 0 comments Download
M dbus/test_service.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M net/base/network_change_notifier_linux.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/base/network_change_notifier_linux_unittest.cc View 2 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
dpapad
8 years, 10 months ago (2012-02-14 20:22:26 UTC) #1 

          

          

        


      

    

    

  











      		
    

  





  
    
  






  Powered by Google App Engine





  
This is Rietveld 408576698