Add support for big integers to the native message format

runtime/vm/snapshot.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
+#include <openssl/crypto.h>
+
 #include "vm/snapshot.h"
 
 #include "platform/assert.h"
 #include "vm/bootstrap.h"
 #include "vm/exceptions.h"
 #include "vm/heap.h"
 #include "vm/object.h"
 #include "vm/object_store.h"
 
 namespace dart {
@@ skipping 517 matching lines @@
       if (object->value.as_bool) {
         WriteIndexedObject(ObjectStore::kTrueValue);
       } else {
         WriteIndexedObject(ObjectStore::kFalseValue);
       }
       break;
     case Dart_CObject::kInt32: {
       WriteSmi(object->value.as_int32);
       break;
     }
+    case Dart_CObject::kBigint: {
+      // Write out the serialization header value for this object.
+      WriteInlinedHeader(object);
+      // Write out the class and tags information.
+      WriteObjectHeader(ObjectStore::kBigintClass, 0);
+      BIGNUM* bn = BN_new();
+      BN_dec2bn(&bn, object->value.as_bigint);
+      char* hex_string = BN_bn2hex(bn);

[siva, 2012/02/09 01:47:27]

Somebody came up with the BigintOperations class in the hope of hiding the fact
that we are using OPENSSL to do the bigint operations and be able to plug in
some other implementation without changing much of the rest of the code.

This assumption is being violated here.

[Søren Gjesse, 2012/02/09 14:08:33]

After changing to using the hex format for the data in the Dart_CObject
structure no bignum operations are needed any more.

+      intptr_t len = strlen(hex_string);
+      WriteIntptrValue(len);
+      for (intptr_t i = 0; i < len; i++) {
+        Write<uint8_t>(hex_string[i]);
+      }
+      OPENSSL_free(hex_string);
+      BN_free(bn);
+      break;
+    }
     case Dart_CObject::kDouble:
       // Write out the serialization header value for this object.
       WriteInlinedHeader(object);
       // Write out the class and tags information.
       WriteObjectHeader(ObjectStore::kDoubleClass, 0);
       // Write double value.
       Write<double>(object->value.as_double);
       break;
     case Dart_CObject::kString: {
       // Write out the serialization header value for this object.
@@ skipping 240 matching lines @@
 
 
 void SnapshotWriterVisitor::VisitPointers(RawObject** first, RawObject** last) {
   for (RawObject** current = first; current <= last; current++) {
     RawObject* raw_obj = *current;
     writer_->WriteObject(raw_obj);
   }
 }
 
 }  // namespace dart