Add support for big integers to the native message format

runtime/vm/dart_api_message.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
+#include <openssl/crypto.h>
+
 #include "vm/dart_api_message.h"
 #include "vm/object.h"
 #include "vm/object_store.h"
 
 namespace dart {
 
 // TODO(sgjesse): When the external message format is done these
 // duplicate constants from snapshot.cc should be removed.
 enum {
   kInstanceId = ObjectStore::kMaxId,
@@ skipping 58 matching lines @@
 }
 
 
 Dart_CObject* ApiMessageReader::AllocateDartCObjectInt32(int32_t val) {
   Dart_CObject* value = AllocateDartCObject(Dart_CObject::kInt32);
   value->value.as_int32 = val;
   return value;
 }
 
 
+Dart_CObject* ApiMessageReader::AllocateDartCObjectBigint(intptr_t length) {
+  // Allocate a Dart_CObject structure followed by an array of chars
+  // for the bigint hex string content. The pointer to the bigint
+  // content is set up to this area.
+  Dart_CObject* value =
+      reinterpret_cast<Dart_CObject*>(
+          alloc_(NULL, 0, sizeof(Dart_CObject) + length + 1));
+  value->value.as_bigint = reinterpret_cast<char*>(value) + sizeof(*value);
+  value->type = Dart_CObject::kBigint;
+  return value;
+}
+
+
 Dart_CObject* ApiMessageReader::AllocateDartCObjectDouble(double val) {
   Dart_CObject* value = AllocateDartCObject(Dart_CObject::kDouble);
   value->value.as_double = val;
   return value;
 }
 
 
 Dart_CObject* ApiMessageReader::AllocateDartCObjectString(intptr_t length) {
   // Allocate a Dart_CObject structure followed by an array of chars
   // for the string content. The pointer to the string content is set
@@ skipping 18 matching lines @@
   value->value.as_array.length = length;
   if (length > 0) {
     value->value.as_array.values = reinterpret_cast<Dart_CObject**>(value + 1);
   } else {
     value->value.as_array.values = NULL;
   }
   return value;
 }
 
 
+uint8_t* ApiMessageReader::AllocateTemp(intptr_t size) {
+  if (Isolate::Current() != NULL) {
+    return reinterpret_cast<uint8_t*>(
+        Isolate::Current()->current_zone()->Allocate(size));
+  } else {
+    return reinterpret_cast<uint8_t*>(
+        ApiNativeScope::Current()->zone()->Allocate(size));
+  }
+}
+
+
 Dart_CObject* ApiMessageReader::ReadInlinedObject(intptr_t object_id) {
   // Read the class header information and lookup the class.
   intptr_t class_header = ReadIntptrValue();
   intptr_t tags = ReadIntptrValue();
   USE(tags);
   intptr_t class_id;
 
   // Reading of regular dart instances is not supported.
   if (SerializedHeaderData::decode(class_header) == kInstanceId) {
     return NULL;
@@ skipping 29 matching lines @@
       if (type_arguments != &type_arguments_marker &&
           type_arguments->type != Dart_CObject::kNull) {
         return NULL;
       }
       for (int i = 0; i < len; i++) {
         value->value.as_array.values[i] = ReadObject();
       }
       return value;
       break;
     }
+    case ObjectStore::kBigintClass: {
+      // Read in the HexCString representation of the bigint.
+      intptr_t len = ReadIntptrValue();
+      char* hex_string = reinterpret_cast<char*>(AllocateTemp(len + 1));

[siva, 2012/02/09 01:47:27]

Why do you use this special temp Allocator and not the regular allocator
registered with this reader object?

[Søren Gjesse, 2012/02/09 14:08:33]

The idea was that temporary data should be freed before returning, but maybe
thats a bad idea.

As suggested we keep the hex string, so temporary allocation for conversion is
not required any more.

+      char* p = hex_string;
+      for (intptr_t i = 0; i < len; i++) {
+        *p = Read<uint8_t>();
+        p++;
+      }
+      *p = '\0';
+      // Convert the hex representation to decimal representation.
+      BIGNUM* bn = BN_new();
+      BN_hex2bn(&bn, hex_string);
+      char* dec_string = BN_bn2dec(bn);

[siva, 2012/02/09 01:47:27]

What is the advantage of converting this into a decimal string and not leaving
it as hex string?

Also ditto comment made elsewhere about exposing the OPENSSL stuff here and not
sticking to the BigIntOperations abstraction.

[Søren Gjesse, 2012/02/09 14:08:33]

Keeping the hex string - no need for bigint operations here any more.

+      len = strlen(dec_string);
+      Dart_CObject* object = AllocateDartCObjectBigint(len);
+      memmove(object->value.as_bigint, dec_string, len + 1);
+      OPENSSL_free(dec_string);
+      BN_free(bn);
+      return object;
+      break;
+    }
     case ObjectStore::kDoubleClass: {
       // Read the double value for the object.
       Dart_CObject* object = AllocateDartCObjectDouble(Read<double>());
       AddBackwardReference(object_id, object);
       return object;
       break;
     }
     case ObjectStore::kOneByteStringClass: {
       intptr_t len = ReadSmiValue();
       intptr_t hash = ReadSmiValue();
@@ skipping 70 matching lines @@
   return ReadObjectImpl(value);
 }
 
 
 void ApiMessageReader::AddBackwardReference(intptr_t id, Dart_CObject* obj) {
   ASSERT((id - kMaxPredefinedObjectIds) == backward_references_.length());
   backward_references_.Add(obj);
 }
 
 }  // namespace dart