Issue 9362014: Remove 6 unused flags.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9362014: Remove 6 unused flags. (Closed)

Created:
8 years, 10 months ago by Erik Corry

Modified:
8 years, 10 months ago

Reviewers:
Vyacheslav Egorov (Chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

More Reviews

Description

Remove 5 unused flags. Committed: https://code.google.com/p/v8/source/detail?r=10646

Patch Set 1 #

Total comments: 1

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+38 lines, -64 lines)			Patch
M	src/flag-definitions.h	View	4 chunks	+0 lines, -16 lines	0 comments	Download
M	src/heap.cc	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	src/hydrogen.cc	View	2 chunks	+2 lines, -4 lines	1 comment	Download
M	src/runtime.cc	View	1 chunk	+33 lines, -35 lines	0 comments	Download
M	src/spaces.h	View	1 chunk	+2 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Chromium)

8 years, 10 months ago (2012-02-08 15:31:12 UTC) #2

lgtm

https://chromiumcodereview.appspot.com/9362014/diff/1/src/hydrogen.cc
File src/hydrogen.cc (left):

https://chromiumcodereview.appspot.com/9362014/diff/1/src/hydrogen.cc#oldcode...
src/hydrogen.cc:2374: if (FLAG_eliminate_dead_phis)
graph()->EliminateUnreachablePhis();
please keep this flag it helps debugging.

Expand Messages | Collapse Messages