Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Side by Side Diff: tools/testing/dart/test_suite.dart

Issue 9362013: Remove implicit --optimize from testing dartc component in release mode (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « tests/utils/utils.status ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #library("test_suite"); 5 #library("test_suite");
6 6
7 #import("dart:io"); 7 #import("dart:io");
8 #import("status_file_parser.dart"); 8 #import("status_file_parser.dart");
9 #import("test_runner.dart"); 9 #import("test_runner.dart");
10 #import("multitest.dart"); 10 #import("multitest.dart");
(...skipping 430 matching lines...) Expand 10 before | Expand all | Expand 10 after
441 '$filePrefix$dartDir/client/testing/unittest/test_controller.js', 441 '$filePrefix$dartDir/client/testing/unittest/test_controller.js',
442 scriptType, 442 scriptType,
443 filePrefix + scriptPath)); 443 filePrefix + scriptPath));
444 htmlTest.closeSync(); 444 htmlTest.closeSync();
445 445
446 List<String> compilerArgs = TestUtils.standardOptions(configuration); 446 List<String> compilerArgs = TestUtils.standardOptions(configuration);
447 String compilerExecutable = TestUtils.compilerPath(configuration); 447 String compilerExecutable = TestUtils.compilerPath(configuration);
448 switch (component) { 448 switch (component) {
449 case 'chromium': 449 case 'chromium':
450 compilerArgs.addAll(['--work', tempDir.path]); 450 compilerArgs.addAll(['--work', tempDir.path]);
451 if (configuration['mode'] == 'release') {
452 compilerArgs.add('--optimize');
453 }
454 compilerArgs.addAll(vmOptions); 451 compilerArgs.addAll(vmOptions);
455 compilerArgs.add('--ignore-unrecognized-flags'); 452 compilerArgs.add('--ignore-unrecognized-flags');
453 // TODO(zundel): remove assumption of generated code from dartc
456 compilerArgs.add('--out'); 454 compilerArgs.add('--out');
457 compilerArgs.add(compiledDartWrapperFilename); 455 compilerArgs.add(compiledDartWrapperFilename);
458 compilerArgs.add(dartWrapperFilename); 456 compilerArgs.add(dartWrapperFilename);
459 // TODO(whesse): Add --fatal-type-errors if needed. 457 // TODO(whesse): Add --fatal-type-errors if needed.
460 break; 458 break;
461 case 'frogium': 459 case 'frogium':
462 case 'webdriver': 460 case 'webdriver':
463 String libdir = configuration['froglib']; 461 String libdir = configuration['froglib'];
464 if (libdir == '') { 462 if (libdir == '') {
465 libdir = '$dartDir/frog/lib'; 463 libdir = '$dartDir/frog/lib';
(...skipping 537 matching lines...) Expand 10 before | Expand all | Expand 10 after
1003 List args = ["--ignore-unrecognized-flags"]; 1001 List args = ["--ignore-unrecognized-flags"];
1004 if (configuration["checked"]) { 1002 if (configuration["checked"]) {
1005 args.add('--enable_asserts'); 1003 args.add('--enable_asserts');
1006 args.add("--enable_type_checks"); 1004 args.add("--enable_type_checks");
1007 } 1005 }
1008 if (configuration["component"] == "leg") { 1006 if (configuration["component"] == "leg") {
1009 args.add("--verbose"); 1007 args.add("--verbose");
1010 args.add("--enable_leg"); 1008 args.add("--enable_leg");
1011 args.add("--leg_only"); 1009 args.add("--leg_only");
1012 } 1010 }
1013 if (configuration["component"] == "dartc") {
1014 if (configuration["mode"] == "release") {
1015 args.add("--optimize");
1016 }
1017 }
1018 return args; 1011 return args;
1019 } 1012 }
1020 } 1013 }
1021 1014
1022 class SummaryReport { 1015 class SummaryReport {
1023 static int total = 0; 1016 static int total = 0;
1024 static int skipped = 0; 1017 static int skipped = 0;
1025 static int noCrash = 0; 1018 static int noCrash = 0;
1026 static int pass = 0; 1019 static int pass = 0;
1027 static int failOk = 0; 1020 static int failOk = 0;
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
1063 * $noCrash tests are expected to be flaky but not crash 1056 * $noCrash tests are expected to be flaky but not crash
1064 * $pass tests are expected to pass 1057 * $pass tests are expected to pass
1065 * $failOk tests are expected to fail that we won't fix 1058 * $failOk tests are expected to fail that we won't fix
1066 * $fail tests are expected to fail that we should fix 1059 * $fail tests are expected to fail that we should fix
1067 * $crash tests are expected to crash that we should fix 1060 * $crash tests are expected to crash that we should fix
1068 * $timeout tests are allowed to timeout 1061 * $timeout tests are allowed to timeout
1069 """; 1062 """;
1070 print(report); 1063 print(report);
1071 } 1064 }
1072 } 1065 }
OLDNEW
« no previous file with comments | « tests/utils/utils.status ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698