Issue 9362009: Correctly enable CSP for about:credits

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9362009: Correctly enable CSP for about:credits (Closed)

Created:
8 years, 10 months ago by jbauman

Modified:
8 years, 10 months ago

Reviewers:
yoshiki, Evan Stade

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Correctly enable CSP for about:credits The header should be put in the HTTP headers, not in the HTML. BUG= TEST= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=121179

Patch Set 1 #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -12 lines)			Patch
M	chrome/browser/resources/about_credits.html	View	2 chunks	+1 line, -6 lines	0 comments	Download
M	chrome/browser/resources/about_credits.tmpl	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/webui/chrome_url_data_manager_backend.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbauman@chromium.org/9362009/1

8 years, 10 months ago (2012-02-09 01:55:51 UTC) #5

commit-bot: I haz the power

8 years, 10 months ago (2012-02-09 02:01:39 UTC) #6

Try job failure for 9362009-1 (retry) on linux_clang for step "update".
It's a second try, previously, step "update" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_clan...

Step "update" is always a major failure.
Look at the try server FAQ for more details.

Expand Messages | Collapse Messages