Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(983)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/testing/perf_testing/create_graph.py

Issue 9361040: Reduce flakiness of browser tests. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: '' Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« tools/testing/dart/test_suite.dart ('K') | « tools/testing/dart/test_suite.dart ('k') | tools/testing/run_selenium.py » ('j') | tools/testing/run_selenium.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/perf_testing/create_graph.py
===================================================================
--- tools/testing/perf_testing/create_graph.py (revision 4018)
+++ tools/testing/perf_testing/create_graph.py (working copy)
@@ -68,6 +68,11 @@
if append:
mode = 'a'
out = open(outfile, mode)
+ if append:
+ # Annoying Windows "feature" -- append doesn't actually append unless you
+ # explicitly go to the end of the file.
+ # http://mail.python.org/pipermail/python-list/2009-October/1221859.html
+ out.seek(0, os.SEEK_END)
p = subprocess.Popen(cmd_list, stdout = out, stderr = subprocess.PIPE,
shell=HAS_SHELL)
output, not_used = p.communicate();
« tools/testing/dart/test_suite.dart ('K') | « tools/testing/dart/test_suite.dart ('k') | tools/testing/run_selenium.py » ('j') | tools/testing/run_selenium.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698