Reduce flakiness of browser tests.

tools/testing/dart/test_runner.dart

Index: tools/testing/dart/test_runner.dart
===================================================================
--- tools/testing/dart/test_runner.dart	(revision 4018)
+++ tools/testing/dart/test_runner.dart	(working copy)
@@ -96,6 +96,10 @@
 class BrowserTestCase extends TestCase {
   String compilerPath;
   List<String> compilerArguments;
+  /** 
+   * Indicates if this test is a rerun, to compensate for flaky browser tests. 
+   */
+  bool isRerun;
 
   BrowserTestCase(displayName,
                     this.compilerPath,
@@ -118,6 +122,7 @@
           '$compilerPath ${Strings.join(compilerArguments, " ")}';
       commandLine = 'compilation command: $compilationCommand\n$commandLine';
     }
+    isRerun = false;
   }
 }
 
@@ -206,7 +211,19 @@
                    stderr, new Date.now().difference(startTime));
     process.close();
     timeoutTimer.cancel();
-    testCase.completed();
+    if (testCase.output.unexpectedOutput && testCase.configuration['verbose']) {
+      print(testCase.output.stdout);
+      print(testCase.output.stderr);
+    }
+    if (testCase is BrowserTestCase && testCase.output.unexpectedOutput && 
+        !testCase.isRerun) {
+      // Selenium tests can be flaky. Try rerunning.
+      testCase.isRerun = true;

[Bill Hesse, 2012/02/08 18:15:06]

Can we print a message in this case?  Is this the best solution for rerunning
tests?  We need the capability to rerun tests for the DumpRenderTree virtual X
server failures - can we add a "request retry" flag to TestOutput, and use that
flag here, so we can request retries in more circumstances?  I think that if we
allow rerunning tests, we should fix the flaky DRT at the same time.

+      this.timedOut = false;
+      this.start();
+    } else {
+      testCase.completed();
+    }
   }
 
   void compilerExitHandler(int exitCode) {