Fix potential flakiness of SocketStreamCloseTest.

tests/standalone/src/SocketStreamCloseTest.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 //
+// VMOptions=
+// VMOptions=--short_socket_read
+// VMOptions=--short_socket_write
+// VMOptions=--short_socket_read --short_socket_write
+//
 // Test socket close events.
 
 #import("dart:io");
 
 final SERVERSHUTDOWN = -1;
 final ITERATIONS = 10;
 
 
 class SocketClose {
 
   SocketClose.start(mode)
       : _receivePort = new ReceivePort(),
         _sendPort = null,
+        _readBytes = 0,
         _dataEvents = 0,
         _closeEvents = 0,
         _errorEvents = 0,
         _iterations = 0,
         _mode = mode {
     new SocketCloseServer().spawn().then((SendPort port) {
       _sendPort = port;
       start();
     });
   }
@@ skipping 12 matching lines @@
       switch (_mode) {
         case 0:
         case 1:
         case 2:
           Expect.fail("No data expected");
           break;
         case 3:
         case 4:
         case 5:
         case 6:
-          List<int> b = new List<int>(100);
-          _socket.readList(b, 0, 100);
-          _dataEvents++;
+          var read = _socket.inputStream.read();
+          _readBytes += read.length;
+          if ((_readBytes % 5) == 0) {
+            _dataEvents++;
+          }
           break;
         default:
           Expect.fail("Unknown test mode");
       }
     }
 
     void closeHandler() {
       _closeEvents++;
       switch (_mode) {
         case 0:
@@ skipping 30 matching lines @@
       _socket.errorHandler = errorHandler;
 
       _iterations++;
       switch (_mode) {
         case 0:
           _socket.inputStream.close();
           proceed();
           break;
         case 1:
           _socket.outputStream.write("Hello".charCodes());
-          _socket.inputStream.close();
-          proceed();
+          _socket.outputStream.noPendingWriteHandler = () {
+            _socket.inputStream.close();
+            proceed();
+          };
           break;
         case 2:
         case 3:
           _socket.outputStream.write("Hello".charCodes());
           break;
         case 4:
           _socket.outputStream.write("Hello".charCodes());
-          _socket.outputStream.close();
+          _socket.outputStream.noPendingWriteHandler = () {
+            _socket.outputStream.close();
+          };
           break;
         case 5:
           _socket.outputStream.write("Hello".charCodes());
           break;
         case 6:
           _socket.outputStream.write("Hello".charCodes());
-          _socket.outputStream.close();
+          _socket.outputStream.noPendingWriteHandler = () {
+            _socket.outputStream.close();
+          };
           break;
         default:
           Expect.fail("Unknown test mode");
       }
     }
 
     _socket = new Socket(SocketCloseServer.HOST, _port);
     Expect.equals(true, _socket !== null);
     _socket.connectHandler = connectHandler;
   }
 
   void start() {
     _receivePort.receive((var message, SendPort replyTo) {
       _port = message;
       proceed();
     });
     _sendPort.send(_mode, _receivePort.toSendPort());
   }
 
   void shutdown() {
     _sendPort.send(SERVERSHUTDOWN, _receivePort.toSendPort());
     _receivePort.close();
 
     switch (_mode) {
       case 0:
       case 1:
         Expect.equals(0, _dataEvents);
-        Expect.equals(10, _closeEvents);
+        Expect.equals(ITERATIONS, _closeEvents);
         break;
       case 2:
         Expect.equals(0, _dataEvents);
         Expect.equals(ITERATIONS, _closeEvents);
         break;
       case 3:
       case 4:
       case 5:
       case 6:
         Expect.equals(ITERATIONS, _dataEvents);
         Expect.equals(ITERATIONS, _closeEvents);
         break;
       default:
         Expect.fail("Unknown test mode");
     }
     Expect.equals(0, _errorEvents);
   }
 
   int _port;
   ReceivePort _receivePort;
   SendPort _sendPort;
   Socket _socket;
   List<int> _buffer;
+  int _readBytes;
   int _dataEvents;
   int _closeEvents;
   int _errorEvents;
   int _iterations;
   int _mode;
 }
 
 class SocketCloseServer extends Isolate {
 
   static final HOST = "127.0.0.1";
 
   SocketCloseServer() : super() {}
 
   void main() {
 
     void connectionHandler(Socket connection) {
 
+      void readBytes(whenFiveBytes) {
+        var read = connection.inputStream.read();
+        _readBytes += read.length;
+        if ((_readBytes % 5) == 0) {
+          whenFiveBytes();
+        }
+      }
+
       void dataHandler() {
-        _dataEvents++;
         switch (_mode) {
           case 0:
             Expect.fail("No data expected");
             break;
           case 1:
-            connection.inputStream.read();
+            readBytes(() => _dataEvents++);
             break;
           case 2:
-            connection.inputStream.read();
-            connection.inputStream.close();
+            readBytes(() {
+              _dataEvents++;
+              connection.inputStream.close();
+            });
             break;
           case 3:
-            connection.inputStream.read();
-            connection.outputStream.write("Hello".charCodes());
-            connection.inputStream.close();
-            //connection.outputStream.close();
+            readBytes(() {
+              _dataEvents++;
+              connection.outputStream.write("Hello".charCodes());

[Søren Gjesse, 2012/02/09 20:19:42]

Maybe we should add two more cases (variants of 3 and 6) with

connection.outputStream.write("Hello".charCodes());
connection.inputStream.close();

without the use of noPendingWriteHandler, as that should be supported as well.

[Mads Ager (google), 2012/02/10 06:56:48]

Done.

+              connection.outputStream.noPendingWriteHandler = () {
+                print("connection.inputStream.close();");

[Søren Gjesse, 2012/02/09 20:19:42]

Debug print.

[Mads Ager (google), 2012/02/10 06:56:48]

Done.

+                connection.inputStream.close();
+              };
+            });
             break;
           case 4:
-            connection.inputStream.read();
-            connection.outputStream.write("Hello".charCodes());
+            readBytes(() {
+              _dataEvents++;
+              connection.outputStream.write("Hello".charCodes());
+            });
             break;
           case 5:
           case 6:
-            connection.inputStream.read();
-            connection.outputStream.write("Hello".charCodes());
-            connection.outputStream.close();
+            readBytes(() {
+              _dataEvents++;
+              connection.outputStream.write("Hello".charCodes());
+              connection.outputStream.noPendingWriteHandler = () {
+                connection.outputStream.close();
+              };
+            });
             break;
           default:
             Expect.fail("Unknown test mode");
         }
       }
 
       void closeHandler() {
         _closeEvents++;
-        connection.close();
+        connection.outputStream.close();
       }
 
       void errorHandler() {
         Expect.fail("Socket error");
       }
 
       _iterations++;
 
       connection.inputStream.dataHandler = dataHandler;
       connection.inputStream.closeHandler = closeHandler;
@@ skipping 37 matching lines @@
         Expect.equals(0, _errorEvents);
         _server.close();
         this.port.close();
       } else {
         new Timer(waitForResult, 100);
       }
     }
 
     this.port.receive((message, SendPort replyTo) {
       if (message != SERVERSHUTDOWN) {
+        _readBytes = 0;
         _errorEvents = 0;
         _dataEvents = 0;
         _closeEvents = 0;
         _iterations = 0;
         _mode = message;
         _server = new ServerSocket(HOST, 0, 10);
         Expect.equals(true, _server !== null);
         _server.connectionHandler = connectionHandler;
         _server.errorHandler = errorHandlerServer;
         replyTo.send(_server.port, null);
       } else {
         new Timer(waitForResult, 0);
       }
     });
   }
 
   ServerSocket _server;
+  int _readBytes;
   int _errorEvents;
   int _dataEvents;
   int _closeEvents;
   int _iterations;
   int _mode;
 }
 
 
 main() {
   // Run the close test in these different "modes".
   // 0: Client closes without sending at all.
   // 1: Client sends and closes.
   // 2: Client sends. Server closes.
   // 3: Client sends. Server responds and closes.
   // 4: Client sends and half-closes. Server responds and closes.
   // 5: Client sends. Server responds and half closes.
   // 6: Client sends and half-closes. Server responds and half closes.
   new SocketClose.start(0);
   new SocketClose.start(1);
   new SocketClose.start(2);
   new SocketClose.start(3);
   new SocketClose.start(4);
   new SocketClose.start(5);
   new SocketClose.start(6);
 }