runtime/bin/eventhandler_macos.cc - Issue 9361032: Fix event handler assert stupidity. :-)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/eventhandler_macos.cc

Issue 9361032: Fix event handler assert stupidity. :-) (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/bin/eventhandler_macos.cc

diff --git a/runtime/bin/eventhandler_macos.cc b/runtime/bin/eventhandler_macos.cc

index 14d67fceeccba0b3c0ac67e152086d9f213e52ba..4f74206c3decc0e1564538708b72e4fc709545e1 100644

--- a/runtime/bin/eventhandler_macos.cc

+++ b/runtime/bin/eventhandler_macos.cc

@@ -59,7 +59,7 @@ static void RemoveFromKqueue(intptr_t kqueue_fd_, SocketData* sd) {

sd->set_write_tracked_by_kqueue(false);

}

if (changes > 0) {

- ASSERT(changes < kMaxChanges);

+ ASSERT(changes <= kMaxChanges);

int status =

TEMP_FAILURE_RETRY(kevent(kqueue_fd_, events, changes, NULL, 0, NULL));

if (status == -1) {

@@ -102,7 +102,7 @@ static void UpdateKqueue(intptr_t kqueue_fd_, SocketData* sd) {