Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(649)

Unified Diff: dart/frog/type.dart

Issue 9361030: Fix for http://code.google.com/p/dart/issues/detail?id=1363: use the simplename for the key, not ... (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dart/frog/minfrog ('k') | dart/frog/world.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/frog/type.dart
===================================================================
--- dart/frog/type.dart (revision 4024)
+++ dart/frog/type.dart (working copy)
@@ -1146,7 +1146,7 @@
var paramName = typeParameters[i].name;
typeMap[paramName] = typeArg;
- names.add(typeArg.name);
+ names.add(typeArg.fullname);
jsnames.add(typeArg.jsname);
}
@@ -1156,13 +1156,13 @@
var jsname = '${jsname}_${Strings.join(jsnames, '\$')}';
var simpleName = '${name}<${Strings.join(names, ', ')}>';
- var ret = _concreteTypes[jsname];
+ var ret = _concreteTypes[simpleName];
if (ret == null) {
ret = new DefinedType(simpleName, library, definition, isClass);
ret.baseGenericType = this;
ret.typeArgsInOrder = typeArgs;
ret._jsname = jsname;
- _concreteTypes[jsname] = ret;
+ _concreteTypes[simpleName] = ret;
ret.resolve();
}
return ret;
« no previous file with comments | « dart/frog/minfrog ('k') | dart/frog/world.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698