Fix for http://code.google.com/p/dart/issues/detail?id=1363: use the simplename for the key, not ...

dart/frog/type.dart

Index: dart/frog/type.dart
===================================================================
--- dart/frog/type.dart	(revision 4024)
+++ dart/frog/type.dart	(working copy)
@@ -1146,7 +1146,7 @@
 
       var paramName = typeParameters[i].name;
       typeMap[paramName] = typeArg;
-      names.add(typeArg.name);
+      names.add(typeArg.fullname);
       jsnames.add(typeArg.jsname);
     }
 
@@ -1156,13 +1156,13 @@
     var jsname = '${jsname}_${Strings.join(jsnames, '\$')}';
     var simpleName = '${name}<${Strings.join(names, ', ')}>';

[kasperl, 2012/02/08 14:00:32]

Hmm. Why doesn't the simpleName start with fullname? The type arguments are all
full names now. Maybe this really isn't a simpleName anymore.

Would it make sense to have both a simpleName and a uniqueName (or something
like that)? The simpleName could be passed into the DefinedType constructor. The
uniqueName could be used as the key into the _concreteTypes.

[ngeoffray, 2012/02/08 16:34:01]

After trying what you suggest, I realized that the 'simpleName' is also used for
uniqueness in other things (for example in the _members map in world.dart).
Therefore, the simpleName (that becomes the name field for the DefinedType) must
be unique.

I believe the reason why it does not have to start with a full name is because
the maps are per-library.

So would you like an extra field 'simpleName' in a type, that will be used to
report errors, or should we just go with one, unique, name?

 
-    var ret = _concreteTypes[jsname];
+    var ret = _concreteTypes[simpleName];
     if (ret == null) {
       ret = new DefinedType(simpleName, library, definition, isClass);

[kasperl, 2012/02/08 14:00:32]

Is the name in a DefinedType used for error reporting? Does this change make the
errors harder to read by adding noise to the type argument names?

[ngeoffray, 2012/02/08 16:34:01]

It does add noise, but since the 'name' is also used for keys in other maps than
concreteType, we need to put the noise.

       ret.baseGenericType = this;
       ret.typeArgsInOrder = typeArgs;
       ret._jsname = jsname;
-      _concreteTypes[jsname] = ret;
+      _concreteTypes[simpleName] = ret;
       ret.resolve();
     }
     return ret;