Issue 9361024: MIPS: Enabled native/cross-compilation for MIPS targets in the gyp system.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9361024: MIPS: Enabled native/cross-compilation for MIPS targets in the gyp system. (Closed)

Created:
8 years, 10 months ago by kalmard

Modified:
8 years, 10 months ago

Reviewers:
kisg, Paul Lind, danno, Jakob Kummerow

CC:
v8-dev

Visibility:
Public.

More Reviews

Description

MIPS: Enabled native/cross-compilation for MIPS targets in the gyp system. Also added selectable mips32r2 mode. BUG= TEST= Committed: https://code.google.com/p/v8/source/detail?r=10642

Patch Set 1 #

Total comments: 1

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -0 lines)			Patch
	M	build/common.gypi	View		2 chunks	+25 lines, -0 lines	1 comment	Download
	M	build/mipsu.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

8 years, 10 months ago (2012-02-08 13:07:34 UTC) #2

LGTM, I'll land.

See my comment below for a suggested future improvement.

http://codereview.chromium.org/9361024/diff/1/build/common.gypi
File build/common.gypi (right):

http://codereview.chromium.org/9361024/diff/1/build/common.gypi#newcode209
build/common.gypi:209: ['mips_arch_variant=="mips32r2"', {
This works for now, but it's a bit brittle: it forces you to specify some value
for mips_arch_variant whenever v8_target_arch=="mips", or gyp will fail. I'd
suggest to add a default value to the top of this file (see the other examples
there for the %-notation).

Expand Messages | Collapse Messages