Issue 9361008: Add Code-related fields to postmortem metadata

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9361008: Add Code-related fields to postmortem metadata (Closed)

Created:
8 years, 10 months ago by dave.pacheco

Modified:
8 years, 9 months ago

Reviewers:
Vyacheslav Egorov (Chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

More Reviews

Description

Add Code-related fields to postmortem metadata Committed: https://code.google.com/p/v8/source/detail?r=10986

Patch Set 1 #

Total comments: 1

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	tools/gen-postmortem-metadata.py	View		1 chunk	+3 lines, -0 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Chromium)

http://codereview.chromium.org/9361008/diff/1/tools/gen-postmortem-metadata.py File tools/gen-postmortem-metadata.py (right): http://codereview.chromium.org/9361008/diff/1/tools/gen-postmortem-metadata.py#newcode119 tools/gen-postmortem-metadata.py:119: 'Code, instruction_start, int, kHeaderSize', instruction_start is of type Address ...

8 years, 10 months ago (2012-02-17 11:31:46 UTC) #1

dave.pacheco

On 2012/02/17 11:31:46, Vyacheslav Egorov wrote: > http://codereview.chromium.org/9361008/diff/1/tools/gen-postmortem-metadata.py > File tools/gen-postmortem-metadata.py (right): > > http://codereview.chromium.org/9361008/diff/1/tools/gen-postmortem-metadata.py#newcode119 ...

8 years, 10 months ago (2012-02-18 23:40:47 UTC) #2

dave.pacheco

8 years, 9 months ago (2012-03-09 17:56:39 UTC) #4

On 2012/03/09 12:35:19, Vyacheslav Egorov wrote:
> lgtm, landed.

Thanks!

Expand Messages | Collapse Messages