Rename PPB_Font to PPB_BrowserFont_Trusted.

Rename PPB_Font to PPB_BrowserFont_Trusted.

PPB_Font can never be exported to NaCl since it relies on in-process WebKit.
So I'm renaming this to BrowserFont_Trusted to imply that this is the way that
the browser would render fonts in the content area (if we export a font API to
NaCl in the future, it will likely be a simpler native font API).

The new API is binary compatible with the old font API, so I map PPB_Font to
PPB_BrowserFont_Trusted for now to avoid breaking Flash (which uses this). When
we update Flash and push it out, we can remove the mapping and PPB_Font.

This does a lot of cleanup of the font implementation. It had complexity from
the fact that it used to run on a different thread. I was able to remove a lot
of code.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=122564

[viettrungluu, 2012-02-14 22:29:42]

http://codereview.chromium.org/9360045/diff/1/ppapi/proxy/resource_creation_p...
File ppapi/proxy/resource_creation_proxy.cc (right):

http://codereview.chromium.org/9360045/diff/1/ppapi/proxy/resource_creation_p...
ppapi/proxy/resource_creation_proxy.cc:39: #include
"ppapi/shared_impl/private/ppb_browser_font_trusted_shared.h"
Errrr, you forgot to add this to the CL.

[brettw, 2012-02-14 23:45:05]

http://codereview.chromium.org/9360045/diff/1/ppapi/proxy/resource_creation_p...
File ppapi/proxy/resource_creation_proxy.cc (right):

http://codereview.chromium.org/9360045/diff/1/ppapi/proxy/resource_creation_p...
ppapi/proxy/resource_creation_proxy.cc:39: #include
"ppapi/shared_impl/private/ppb_browser_font_trusted_shared.h"
Uploaded.

[viettrungluu, 2012-02-15 04:32:46]

Lots of boilerplate-ish changes, which look okay to me, but ... it's kind of
hard to review carefully. Would you mind adding a test of some sort? That would
give me a lot more confidence. (Bonus points if you also have a test to verify
that the old interface still works.)

[viettrungluu, 2012-02-15 04:37:24]

http://codereview.chromium.org/9360045/diff/6001/ppapi/thunk/interfaces_ppb_p...
File ppapi/thunk/interfaces_ppb_private.h (right):

http://codereview.chromium.org/9360045/diff/6001/ppapi/thunk/interfaces_ppb_p...
ppapi/thunk/interfaces_ppb_private.h:39: PROXIED_IFACE(PPB_Instance,
PPB_FONT_DEV_INTERFACE_0_6,
I suppose you could also just remove the old ppb_fond_dev.{idl,h} (and add a
define in some header for PPB_FONT_DEV_INTERFACE_0_6).

(Though that would make verifying backwards compatibility a tad harder.)

[viettrungluu, 2012-02-15 04:42:46]

http://codereview.chromium.org/9360045/diff/6001/ppapi/shared_impl/private/pp...
File ppapi/shared_impl/private/ppb_browser_font_trusted_shared.cc (right):

http://codereview.chromium.org/9360045/diff/6001/ppapi/shared_impl/private/pp...
ppapi/shared_impl/private/ppb_browser_font_trusted_shared.cc:295:
TRACE_EVENT0("ppapi WebKit thread", "FontImpl::DrawTextAt");
eh?

[brettw, 2012-02-16 19:19:26]

Now with sweet tests.

I also added a C++ wrapper for it that does autofallback to PPB_Font.

http://codereview.chromium.org/9360045/diff/6001/ppapi/shared_impl/private/pp...
File ppapi/shared_impl/private/ppb_browser_font_trusted_shared.cc (right):

http://codereview.chromium.org/9360045/diff/6001/ppapi/shared_impl/private/pp...
ppapi/shared_impl/private/ppb_browser_font_trusted_shared.cc:295:
TRACE_EVENT0("ppapi WebKit thread", "FontImpl::DrawTextAt");
Just copied from the old code, I removed these.

[viettrungluu, 2012-02-16 20:31:18]

lgtm w/comment

http://codereview.chromium.org/9360045/diff/15001/ppapi/tests/test_browser_fo...
File ppapi/tests/test_browser_font.cc (right):

http://codereview.chromium.org/9360045/diff/15001/ppapi/tests/test_browser_fo...
ppapi/tests/test_browser_font.cc:49: int32_t length1 =
font.MeasureText(pp::BrowserFontTextRun("WWW"));
Do you also want to check that length1 > 0?

[commit-bot: I haz the power, 2012-02-16 23:25:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/brettw@chromium.org/9360045/16004

[commit-bot: I haz the power, 2012-02-16 23:25:29]

Presubmit check for 9360045-16004 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
If this change has an associated bug, add BUG=[bug number].

If this change requires manual test instructions to QA team, add
TEST=[instructions].

** Presubmit ERRORS **
Missing LGTM from an OWNER for: webkit/glue/webkit_glue.gypi

Presubmit checks took 3.6s to calculate.