cleanup postProcess step and output obsolete.json file

utils/apidoc/mdn/prettyPrint.dart

-#library("postProcess");
+#library("prettyPrint");
 
 #import("../../../frog/lib/node/node.dart");
 #import("dart:json");
-
-// TODO(jacobr): this file conflates pretty printing of the JSON database with
-// filtering the database to select the best matches per file.
-// Separate out the two tasks as quick and dirty coding is correct for pretty
-// printing but more carefully documented code is required for the code
-// filtering the database.
-Map<String, List> database;
-Map<String, Map> allProps;
-Set<String> matchedTypes;
+#import("util.dart");
 
 String orEmpty(String str) {
   return str == null ? "" : str;
 }
 
-/** Returns whether the type has any member matching the specified name. */
-bool hasAny(String type, String prop) {
-  final data = allProps[type];
-  return data['properties'].containsKey(prop) ||
-      data['methods'].containsKey(prop) ||
-      data['constants'].containsKey(prop);
-}
-
 List<String> sortStringCollection(Collection<String> collection) {
   final out = <String>[];
   out.addAll(collection);
   out.sort((String a, String b) => a.compareTo(b));
   return out;
 }
 
-/**
- * Return the members from an [entry] as Map of member names to member
- * objects.
- */
-Map getMembersMap(Map entry) {
-  List<Map> rawMembers = entry["members"];
-  final members = {};
-  for (final entry in rawMembers) {
-    members[entry['name']] = entry;
-  }
-  return members;
-}
-
 int addMissing(StringBuffer sb, String type, Map members) {
   int total = 0;
   /**
    * Add all missing members to the string output and return the number of
    * missing members.
    */
   void addMissingHelper(String propType) {
     Map expected = allProps[type][propType];
     if (expected != null) {
       for(final name in sortStringCollection(expected.getKeys())) {
@@ skipping 10 matching lines @@
       }
     }
   }
 
   addMissingHelper('properties');
   addMissingHelper('methods');
   addMissingHelper('constants');
   return total;
 }
 
-/**
- * Score entries using similarity heuristics calculated from the observed and
- * expected list of members. We could be much less naive and penalize spurious
- * methods, prefer entries with class level comments, etc. This method is
- * needed becase we extract entries for each of the top search results for
- * each class name and rely on these scores to determine which entry was
- * best.  Typically all scores but one will be zero.  Multiple pages have
- * non-zero scores when MDN has multiple pages on the same class or pages on
- * similar classes (e.g. HTMLElement and Element), or pages on Mozilla
- * specific classes that are similar to DOM classes (Console).
- */
-num scoreEntry(Map entry, String type) {
-  num score = 0;
-  // TODO(jacobr): consider removing skipped entries completely instead of
-  // just giving them lower scores.
-  if (!entry.containsKey('skipped')) {
-    score++;
-  }
-  if (entry.containsKey("members")) {
-    Map members = getMembersMap(entry);
-    for (String name in members.getKeys()) {
-      if (hasAny(type, name)) {
-        score++;
-      }
-    }
-  }
-  return score;
-}
-
-/**
- * Given a list of candidates for the documentation for a type, find the one
- * that is the best.
- */
-Map pickBestEntry(List entries, String type) {
-  num bestScore = -1;
-  Map bestEntry;
-  for (Map entry in entries) {
-    if (entry != null) {
-      num score = scoreEntry(entry, type);
-      if (score > bestScore) {
-        bestScore = score;
-        bestEntry = entry;
-      }
-    }
-  }
-  return bestEntry;
-}
-
 void main() {
   // Database of code documentation.
-  database = JSON.parse(fs.readFileSync('output/database.json', 'utf8'));
-  // Database of expected property names for each type in WebKit.
-  allProps = JSON.parse(fs.readFileSync('data/dartIdl.json', 'utf8'));
+  final Map<String, Map> database = JSON.parse(fs.readFileSync(
+          'output/database.filtered.json', 'utf8'));
+
   // Types we have documentation for.
   matchedTypes = new Set<String>();
   int numMissingMethods = 0;
   int numFoundMethods = 0;
   int numExtraMethods = 0;
   int numGen = 0;
   int numSkipped = 0;
   final sbSkipped = new StringBuffer();
   final sbAllExamples = new StringBuffer();
-  final filteredDb = {};
 
   // Table rows for all obsolete members.
   final sbObsolete = new StringBuffer();
   // Main documentation file.
   final sb = new StringBuffer();
 
   // TODO(jacobr): switch to using a real template system instead of string
   // interpolation combined with StringBuffers.
   sb.add("""
 <html>
@@ skipping 69 matching lines @@
             }
     </style>
     <title>Doc Dump</title>
   </head>
   <body>
     <h1>Doc Dump</h1>
     <ul>
       <li><a href="#dart_summary">Summary</a></li>
     </li>
 """);
-
   for (String type in sortStringCollection(database.getKeys())) {
-    Map entry = pickBestEntry(database[type], type);
-    filteredDb[type] = entry;
+        final entry = database[type];
     if (entry == null || entry.containsKey('skipped')) {
       numSkipped++;
       sbSkipped.add("""
     <li id="$type">
       <a target="_blank" href="http://www.google.com/cse?cx=017193972565947830266%3Awpqsk6dy6ee&ie=UTF-8&q=$type">
         $type
       </a>
       --
       Title: ${entry == null ? "???" : entry["title"]} -- Issue:
       ${entry == null ? "???" : entry['cause']}
@@ skipping 14 matching lines @@
       sbMembers.add("""
             <div class="members">
           <h3><span class="debug">[dart]</span> Members</h3>
           <table>
             <tbody>
               <tr>
                 <th>Name</th><th>Description</th><th>IDL</th><th>Status</th>
               </tr>
 """);
       for (String name in sortStringCollection(members.getKeys())) {
-          Map memberData = members[name];
-          bool unknown = !hasAny(type, name);
-          StringBuffer classes = new StringBuffer();
+        Map memberData = members[name];
+        bool unknown = !hasAny(type, name);
+        StringBuffer classes = new StringBuffer();
         if (unknown) classes.add("unknown ");
         if (unknown) {
           numExtraMethods++;
         } else {
           numFoundMethods++;
         }
 
         final sbMember = new StringBuffer();
 
         if (memberData.containsKey('url')) {
@@ skipping 216 matching lines @@
           <th>Description</th>
           <th>IDL</th>
           <th>Status</th>
         </tr>
 $sbObsolete
     </tbody>
    </table>
   </body>
  </html>
  """);
-
-  fs.writeFileSync("output/database.filtered.json",
-      JSON.stringify(filteredDb));
-}
+}