Source in most stuff.

dart/frog/leg/elements/elements.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #library('elements');
 
 #import('../tree/tree.dart');
 #import('../scanner/scannerlib.dart');
 #import('../leg.dart');  // TODO(karlklose): we only need type.
 #import('../util/util.dart');
@@ skipping 305 matching lines @@
   if (identifier === null) {
     compiler.cancel('library prefixes not handled',
                     node: typeAnnotation.typeName);
   }
   final SourceString name = identifier.source;
   Element element = library.find(name);
   if (element !== null && element.kind === ElementKind.CLASS) {
     // TODO(karlklose): substitute type parameters.
     return element.computeType(compiler);
   }
-  return compiler.types.lookup(name);
+  Type type = compiler.types.lookup(name);

[kasperl, 2012/02/15 09:22:30]

Would it be cleaner to have a way of querying if the types contains a certain
name and deal with that first? I'm always a bit worried when I see lookup
functions that happily return null.

[ahe, 2012/02/15 09:46:55]

Interesting difference of opinion here: I really prefer avoiding looking up
something twice. Or is it the name of the method that you don't like?

[kasperl, 2012/02/15 10:01:29]

Yeah, I think it would be neater with something like 

compiler.types.lookupIfAbsent(
  name, 
  () => compiler.types.dynamicType);

or maybe just move the logic into compiler.types.lookup. Usually I prefer having
something like lookup throw an error if it cannot find the thing you're looking
for because it is so easy to write code under that assumption.

[ahe, 2012/02/15 15:08:42]

Actually, this entire method is somewhat broken. I plan to overhaul this a some
point, but I'm not sure what to do. Karl and I had a conversation about this,
but we didn't come up with anything yet.

+  if (type === null) {
+    type = compiler.types.dynamicType;
+  }
+  return type;
 }
 
 class FunctionParameters {
   Link<Element> requiredParameters;
   Link<Element> optionalParameters;
   int requiredParameterCount;
   int optionalParameterCount;
   FunctionParameters(this.requiredParameters,
                      this.optionalParameters,
                      this.requiredParameterCount,
@@ skipping 357 matching lines @@
     else if (str === '>=') str = 'ge';
     else if (str === '>') str = 'gt';
     else if (str === '<=') str = 'le';
     else if (str === '<') str = 'lt';
     else if (str === '&' || str === '&=') str = 'and';
     else if (str === '^' || str === '^=') str = 'xor';
     else if (str === '|' || str === '|=') str = 'or';
     return new SourceString('$receiver\$$str');
   }
 }