Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 9359034: A bunch of fixes in idl database generator. (Closed)

Created:
8 years, 10 months ago by podivilov
Modified:
8 years, 10 months ago
Reviewers:
sra1
CC:
reviews_dartlang.org
Visibility:
Public.

Description

A bunch of fixes in idl database generator. * Enable SHADOW_DOM * Add "mediastream" directory to idl search path * Fix attribute exceptions rendering R=sra@google.com Committed: https://code.google.com/p/dart/source/detail?r=4253

Patch Set 1 #

Patch Set 2 : Generated files. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+967 lines, -59 lines) Patch
M client/dom/dom.dart View 1 6 chunks +13 lines, -0 lines 0 comments Download
M client/dom/dom_dummy.dart View 1 6 chunks +13 lines, -0 lines 0 comments Download
M client/dom/dom_frog.dart View 1 12 chunks +23 lines, -0 lines 0 comments Download
M client/dom/frog/dom_frog.dart View 1 16 chunks +309 lines, -2 lines 0 comments Download
M client/dom/generated/src/frog/DOMURL.dart View 1 1 chunk +1 line, -1 line 0 comments Download
A client/dom/generated/src/frog/HTMLContentElement.dart View 1 1 chunk +5 lines, -0 lines 0 comments Download
A client/dom/generated/src/frog/LocalMediaStream.dart View 1 1 chunk +5 lines, -0 lines 0 comments Download
A client/dom/generated/src/frog/MediaStream.dart View 1 1 chunk +23 lines, -0 lines 0 comments Download
A client/dom/generated/src/frog/MediaStreamEvent.dart View 1 1 chunk +5 lines, -0 lines 0 comments Download
A client/dom/generated/src/frog/MediaStreamList.dart View 1 1 chunk +7 lines, -0 lines 0 comments Download
A client/dom/generated/src/frog/MediaStreamTrack.dart View 1 1 chunk +9 lines, -0 lines 0 comments Download
A client/dom/generated/src/frog/MediaStreamTrackList.dart View 1 1 chunk +7 lines, -0 lines 0 comments Download
M client/dom/generated/src/frog/Navigator.dart View 1 1 chunk +2 lines, -0 lines 0 comments Download
A client/dom/generated/src/frog/NavigatorUserMediaError.dart View 1 1 chunk +7 lines, -0 lines 0 comments Download
A client/dom/generated/src/frog/PeerConnection.dart View 1 1 chunk +43 lines, -0 lines 0 comments Download
A client/dom/generated/src/frog/ShadowRoot.dart View 1 1 chunk +5 lines, -0 lines 0 comments Download
M client/dom/generated/src/interface/DOMURL.dart View 1 1 chunk +1 line, -1 line 0 comments Download
A + client/dom/generated/src/interface/HTMLContentElement.dart View 1 1 chunk +2 lines, -4 lines 0 comments Download
A + client/dom/generated/src/interface/LocalMediaStream.dart View 1 1 chunk +2 lines, -4 lines 0 comments Download
A client/dom/generated/src/interface/MediaStream.dart View 1 1 chunk +28 lines, -0 lines 0 comments Download
A + client/dom/generated/src/interface/MediaStreamEvent.dart View 1 1 chunk +2 lines, -4 lines 0 comments Download
A + client/dom/generated/src/interface/MediaStreamList.dart View 1 1 chunk +3 lines, -3 lines 0 comments Download
A + client/dom/generated/src/interface/MediaStreamTrack.dart View 1 1 chunk +5 lines, -3 lines 0 comments Download
A + client/dom/generated/src/interface/MediaStreamTrackList.dart View 1 1 chunk +3 lines, -3 lines 0 comments Download
M client/dom/generated/src/interface/Navigator.dart View 1 1 chunk +2 lines, -0 lines 0 comments Download
A + client/dom/generated/src/interface/NavigatorUserMediaError.dart View 1 1 chunk +3 lines, -3 lines 0 comments Download
A + client/dom/generated/src/interface/NavigatorUserMediaErrorCallback.dart View 1 1 chunk +2 lines, -7 lines 0 comments Download
A + client/dom/generated/src/interface/NavigatorUserMediaSuccessCallback.dart View 1 1 chunk +2 lines, -7 lines 0 comments Download
A client/dom/generated/src/interface/PeerConnection.dart View 1 1 chunk +48 lines, -0 lines 0 comments Download
A + client/dom/generated/src/interface/ShadowRoot.dart View 1 1 chunk +2 lines, -4 lines 0 comments Download
A + client/dom/generated/src/interface/SignalingCallback.dart View 1 1 chunk +2 lines, -7 lines 0 comments Download
M client/dom/generated/src/wrapping/_DOMURLWrappingImplementation.dart View 1 1 chunk +11 lines, -3 lines 0 comments Download
A client/dom/generated/src/wrapping/_HTMLContentElementWrappingImplementation.dart View 1 1 chunk +21 lines, -0 lines 0 comments Download
A client/dom/generated/src/wrapping/_LocalMediaStreamWrappingImplementation.dart View 1 1 chunk +21 lines, -0 lines 0 comments Download
A client/dom/generated/src/wrapping/_MediaStreamEventWrappingImplementation.dart View 1 1 chunk +18 lines, -0 lines 0 comments Download
A client/dom/generated/src/wrapping/_MediaStreamListWrappingImplementation.dart View 1 1 chunk +23 lines, -0 lines 0 comments Download
A client/dom/generated/src/wrapping/_MediaStreamTrackListWrappingImplementation.dart View 1 1 chunk +23 lines, -0 lines 0 comments Download
A client/dom/generated/src/wrapping/_MediaStreamTrackWrappingImplementation.dart View 1 1 chunk +27 lines, -0 lines 0 comments Download
A client/dom/generated/src/wrapping/_MediaStreamWrappingImplementation.dart View 1 1 chunk +62 lines, -0 lines 0 comments Download
A client/dom/generated/src/wrapping/_NavigatorUserMediaErrorWrappingImplementation.dart View 1 1 chunk +18 lines, -0 lines 0 comments Download
M client/dom/generated/src/wrapping/_NavigatorWrappingImplementation.dart View 1 1 chunk +12 lines, -0 lines 0 comments Download
A client/dom/generated/src/wrapping/_PeerConnectionWrappingImplementation.dart View 1 1 chunk +101 lines, -0 lines 0 comments Download
A client/dom/generated/src/wrapping/_ShadowRootWrappingImplementation.dart View 1 1 chunk +18 lines, -0 lines 0 comments Download
M client/dom/scripts/fremontcutbuilder.py View 3 chunks +3 lines, -0 lines 0 comments Download
M client/dom/scripts/idlrenderer.py View 2 chunks +2 lines, -3 lines 0 comments Download
M client/dom/wrapping_dom.dart View 1 12 chunks +23 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
podivilov
8 years, 10 months ago (2012-02-14 14:15:05 UTC) #1
sra1
LGTM. Are there changes in the generated interfaces? It is OK to push those as ...
8 years, 10 months ago (2012-02-14 19:56:43 UTC) #2
sra1
On 2012/02/14 19:56:43, sra1 wrote: > LGTM. > > Are there changes in the generated ...
8 years, 10 months ago (2012-02-14 19:57:57 UTC) #3
podivilov
8 years, 10 months ago (2012-02-15 08:32:00 UTC) #4
On 2012/02/14 19:57:57, sra1 wrote:
> On 2012/02/14 19:56:43, sra1 wrote:
> > LGTM.
> > 
> > Are there changes in the generated interfaces?
> > It is OK to push those as a second CL but it would nice to include them
here.
> 
> Should MICRODATA be included - is it in the V8 bindings?

Currently MICRODATA is disabled in chrome, see
http://code.google.com/p/chromium/source/search?q=file%3A.gypi+enable_microda....
We can generate Dart interfaces for it, but native callbacks would not compile.

Powered by Google App Engine
This is Rietveld 408576698