Add Navier-Stokes benchmark.

Add Navier-Stokes benchmark.

R=danno@chromium.org,kasperl@chromium.com,stefanoc@chromium.org,sandholm@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=10705

[ulan, 2012-02-14 10:44:16]

Please take a look. I addressed all comments from the previous CL (9361038)
except:

> Could we make this 2 space indent instead of 4
I am leaving 4 space indentation to be consistent with Oliver's code.

> Is there anyway you can check that the benchmark behaves correctly based on
some of these counters? 
It's difficult to check the correctness since the benchmark simulates fluids.

I also simplified the code for adding new points.

[kasperl, 2012-02-14 10:50:17]

LGTM.

https://chromiumcodereview.appspot.com/9359033/diff/4001/benchmarks/navier-st...
File benchmarks/navier-stokes.js (right):

https://chromiumcodereview.appspot.com/9359033/diff/4001/benchmarks/navier-st...
benchmarks/navier-stokes.js:27: var NavierStokes = new
BenchmarkSuite('Navier-Stokes', 1484000,
Maybe make the string NavierStokes instead of using the hyphen? That makes it
more consistent with EarlyBoyer.

https://chromiumcodereview.appspot.com/9359033/diff/4001/benchmarks/navier-st...
benchmarks/navier-stokes.js:27: var NavierStokes = new
BenchmarkSuite('Navier-Stokes', 1484000,
Where did you get the 1484000 number from? You may want to coordinate this with
Anders so that the new benchmark has a score of 100 on the reference machine.

https://chromiumcodereview.appspot.com/9359033/diff/4001/benchmarks/navier-st...
benchmarks/navier-stokes.js:50: function teardownNavierStokes()
tearDownNavierStokes (tDNS not tdNS) to be consistent with base.js. Maybe
setup+teardown would be more consistent than setup+tearDown, but for now I would
keep it consistent with base.js.

[sandholm, 2012-02-14 13:11:09]

On 2012/02/14 10:50:17, kasperl wrote:
> LGTM.
> 
>
https://chromiumcodereview.appspot.com/9359033/diff/4001/benchmarks/navier-st...
> File benchmarks/navier-stokes.js (right):
> 
>
https://chromiumcodereview.appspot.com/9359033/diff/4001/benchmarks/navier-st...
> benchmarks/navier-stokes.js:27: var NavierStokes = new
> BenchmarkSuite('Navier-Stokes', 1484000,
> Maybe make the string NavierStokes instead of using the hyphen? That makes it
> more consistent with EarlyBoyer.
> 
>
https://chromiumcodereview.appspot.com/9359033/diff/4001/benchmarks/navier-st...
> benchmarks/navier-stokes.js:27: var NavierStokes = new
> BenchmarkSuite('Navier-Stokes', 1484000,
> Where did you get the 1484000 number from? You may want to coordinate this
with
> Anders so that the new benchmark has a score of 100 on the reference machine.

Just checked. Perfect match. LGTM.
> 
>
https://chromiumcodereview.appspot.com/9359033/diff/4001/benchmarks/navier-st...
> benchmarks/navier-stokes.js:50: function teardownNavierStokes()
> tearDownNavierStokes (tDNS not tdNS) to be consistent with base.js. Maybe
> setup+teardown would be more consistent than setup+tearDown, but for now I
would
> keep it consistent with base.js.

[ulan, 2012-02-14 13:17:12]

Thank you for the comments!

I uploaded new patch set, will land soon.

http://codereview.chromium.org/9359033/diff/4001/benchmarks/navier-stokes.js
File benchmarks/navier-stokes.js (right):

http://codereview.chromium.org/9359033/diff/4001/benchmarks/navier-stokes.js#...
benchmarks/navier-stokes.js:27: var NavierStokes = new
BenchmarkSuite('Navier-Stokes', 1484000,
On 2012/02/14 10:50:17, kasperl wrote:
> Maybe make the string NavierStokes instead of using the hyphen? That makes it
> more consistent with EarlyBoyer.

Done.

http://codereview.chromium.org/9359033/diff/4001/benchmarks/navier-stokes.js#...
benchmarks/navier-stokes.js:27: var NavierStokes = new
BenchmarkSuite('Navier-Stokes', 1484000,
On 2012/02/14 10:50:17, kasperl wrote:
> Where did you get the 1484000 number from? You may want to coordinate this
with
> Anders so that the new benchmark has a score of 100 on the reference machine.

Done.

http://codereview.chromium.org/9359033/diff/4001/benchmarks/navier-stokes.js#...
benchmarks/navier-stokes.js:50: function teardownNavierStokes()
On 2012/02/14 10:50:17, kasperl wrote:
> tearDownNavierStokes (tDNS not tdNS) to be consistent with base.js. Maybe
> setup+teardown would be more consistent than setup+tearDown, but for now I
would
> keep it consistent with base.js.

Done.