Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 9358067: Very preliminary work for ninja on Windows (Closed)

Created:
8 years, 10 months ago by scottmg
Modified:
8 years, 10 months ago
Reviewers:
Nico, Evan Martin
CC:
gyp-developer_googlegroups.com, Nico
Visibility:
Public.

Description

Very preliminary work for ninja on Windows. Only trying to get a first test passing: gyptest.py test/hello/gyptest-all.py -f ninja builds obj, links, and runs, but fails the up_to_date test because there's no .d handling yet. (Is the deplist branch of ninja the best starting point for that?) Committed: https://code.google.com/p/gyp/source/detail?r=1200

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -24 lines) Patch
M gyptest.py View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M pylib/gyp/generator/ninja.py View 1 2 4 9 chunks +76 lines, -22 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
scottmg
https://chromiumcodereview.appspot.com/9358067/diff/1/pylib/gyp/generator/ninja.py File pylib/gyp/generator/ninja.py (right): https://chromiumcodereview.appspot.com/9358067/diff/1/pylib/gyp/generator/ninja.py#newcode88 pylib/gyp/generator/ninja.py:88: depth = len(path.split(os.path.sep)) This was *sneaky*! Paths were ../blah ...
8 years, 10 months ago (2012-02-14 18:58:47 UTC) #1
Evan Martin
https://chromiumcodereview.appspot.com/9358067/diff/1/pylib/gyp/generator/ninja.py File pylib/gyp/generator/ninja.py (right): https://chromiumcodereview.appspot.com/9358067/diff/1/pylib/gyp/generator/ninja.py#newcode46 pylib/gyp/generator/ninja.py:46: # these back in later? See make.py: def CalculateVariables(default_variables, ...
8 years, 10 months ago (2012-02-14 19:07:28 UTC) #2
Nico
https://chromiumcodereview.appspot.com/9358067/diff/1/pylib/gyp/generator/ninja.py File pylib/gyp/generator/ninja.py (right): https://chromiumcodereview.appspot.com/9358067/diff/1/pylib/gyp/generator/ninja.py#newcode46 pylib/gyp/generator/ninja.py:46: # these back in later? On 2012/02/14 19:07:29, Evan ...
8 years, 10 months ago (2012-02-14 19:14:10 UTC) #3
scottmg
On 2012/02/14 19:07:28, Evan Martin wrote: > Is there value in allowing us to generate ...
8 years, 10 months ago (2012-02-14 19:24:19 UTC) #4
scottmg
On 2012/02/14 19:14:10, Nico wrote: > On 2012/02/14 19:07:29, Evan Martin wrote: > > > ...
8 years, 10 months ago (2012-02-14 19:24:42 UTC) #5
Evan Martin
8 years, 10 months ago (2012-02-14 19:28:51 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld 408576698