BrowsingDataRemover: Enable origin-based deletion for quota-managed data.

BrowsingDataRemover: Enable origin-based deletion for quota-managed data.

BUG=113966
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=122570

[Mike West, 2012-02-14 10:22:26]

Assuming you two love love love http://codereview.chromium.org/9379008/, this CL
should do the same for quota-managed data, which is much more straightforward.

DO NOT COMMIT without landing http://codereview.chromium.org/9379008/ first.

[Mike West, 2012-02-17 13:10:38]

Now that the history bits have landed, this should be pretty straightforward.

Friendly ping? :)

[Bernhard Bauer, 2012-02-17 13:28:49]

LGTM with a suggestion below:

https://chromiumcodereview.appspot.com/9358050/diff/5001/chrome/browser/brows...
File chrome/browser/browsing_data_remover_unittest.cc (right):

https://chromiumcodereview.appspot.com/9358050/diff/5001/chrome/browser/brows...
chrome/browser/browsing_data_remover_unittest.cc:611: new
RemoveQuotaManagedDataTester());
I think you can directly allocate this object on the stack.

https://chromiumcodereview.appspot.com/9358050/diff/5001/chrome/browser/brows...
chrome/browser/browsing_data_remover_unittest.cc:727:
scoped_ptr<RemoveQuotaManagedDataTester> tester(
Same here.

[Mike West, 2012-02-17 16:40:43]

http://codereview.chromium.org/9358050/diff/5001/chrome/browser/browsing_data...
File chrome/browser/browsing_data_remover_unittest.cc (right):

http://codereview.chromium.org/9358050/diff/5001/chrome/browser/browsing_data...
chrome/browser/browsing_data_remover_unittest.cc:611: new
RemoveQuotaManagedDataTester());
On 2012/02/17 13:28:49, Bernhard Bauer wrote:
> I think you can directly allocate this object on the stack.

I think I agree, but I've done it this way in every other test. I'll land this
change as-is, and clean it up in another CL (which I'll throw on your lap on
Monday: http://crbug.com/114776)

[commit-bot: I haz the power, 2012-02-17 16:40:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mkwst@chromium.org/9358050/13001

[commit-bot: I haz the power, 2012-02-17 18:06:54]

Can't apply patch for file chrome/browser/browsing_data_remover.cc.
While running patch -p1 --forward --force;
patching file chrome/browser/browsing_data_remover.cc
Hunk #1 FAILED at 289.
Hunk #2 succeeded at 601 (offset 6 lines).
1 out of 2 hunks FAILED -- saving rejects to file
chrome/browser/browsing_data_remover.cc.rej

[commit-bot: I haz the power, 2012-02-17 18:56:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mkwst@chromium.org/9358050/19003

[commit-bot: I haz the power, 2012-02-17 20:23:15]

Change committed as 122570