Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Unified Diff: ui/views/controls/textfield/native_textfield_views.h

Issue 9358049: Implement STYLE_LOWERCASE style for Aura NativeTextfield. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add MaybeLowerCase(), test descriptions and cursor position assertion. Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/controls/textfield/native_textfield_views.h
diff --git a/ui/views/controls/textfield/native_textfield_views.h b/ui/views/controls/textfield/native_textfield_views.h
index 83341e1db521da1aa9fff5544a7080ebea6cbd33..2718c7c5b33acef413c6562061b66339bd79ce4a 100644
--- a/ui/views/controls/textfield/native_textfield_views.h
+++ b/ui/views/controls/textfield/native_textfield_views.h
@@ -197,7 +197,7 @@ class VIEWS_EXPORT NativeTextfieldViews : public TouchSelectionClientView,
// changed.
void UpdateAfterChange(bool text_changed, bool cursor_changed);
- // Utility function to prepare the context menu..
+ // Utility function to prepare the context menu.
void UpdateContextMenu();
// Convenience method to call InputMethod::OnTextInputTypeChanged();
@@ -235,6 +235,9 @@ class VIEWS_EXPORT NativeTextfieldViews : public TouchSelectionClientView,
// exceeds the drag threshold.
bool ExceededDragThresholdFromLastClickLocation(const MouseEvent& event);
+ // Converts |text| to lower case if |textfield_| has STYLE_LOWERCASE style.
+ void MaybeLowerCase(string16* text);
msw 2012/04/12 16:15:29 Please rename this GetTextForDisplay or similar fo
kochi 2012/04/13 09:44:09 Done.
+
// Checks if a char is ok to be inserted into the textfield. The |ch| is a
// modified character, i.e., modifiers took effect when generating this char.
static bool ShouldInsertChar(char16 ch, int flags);

Powered by Google App Engine
This is Rietveld 408576698