Implement STYLE_LOWERCASE style for Aura NativeTextfield.

ui/views/controls/textfield/native_textfield_views_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 #include <vector>
 
 #include "base/auto_reset.h"
 #include "base/bind.h"
 #include "base/bind_helpers.h"
@@ skipping 343 matching lines @@
   EXPECT_STR_EQ("this is a test", model_->GetText());
   EXPECT_STR_EQ("this is a test", textfield_->text());
   EXPECT_TRUE(last_contents_.empty());
 
   EXPECT_EQ(string16(), textfield_->GetSelectedText());
   textfield_->SelectAll();
   EXPECT_STR_EQ("this is a test", textfield_->GetSelectedText());
   EXPECT_TRUE(last_contents_.empty());
 }
 
+TEST_F(NativeTextfieldViewsTest, ModelChangesTestLowerCase) {
+  // Check if |model_|'s text is properly lowercased for STYLE_LOWERCASE.
+  InitTextfield(Textfield::STYLE_LOWERCASE);
+  EXPECT_EQ(0U, textfield_->GetCursorPosition());

[msw, 2012/04/13 18:13:25]

Why do these test check the cursor position at all? It seems irrelevant.
Please these unnecessary checks (I count 9 overall in these new tests). 

[kochi, 2012/04/16 04:54:18]

That's for addressing sky's review comment
"Also, can you add assertions that the caret position doesn't get mangled."
so we can make sure cursor position won't get changed
by SetText() etc. accidentally.

On 2012/04/13 18:13:25, msw wrote:

+
+  last_contents_.clear();
+  textfield_->SetText(ASCIIToUTF16("THIS IS"));
+  EXPECT_EQ(0U, textfield_->GetCursorPosition());
+
+  EXPECT_STR_EQ("this is", model_->GetText());
+  EXPECT_STR_EQ("THIS IS", textfield_->text());
+  EXPECT_TRUE(last_contents_.empty());
+
+  textfield_->AppendText(ASCIIToUTF16(" A TEST"));
+  EXPECT_EQ(0U, textfield_->GetCursorPosition());
+  EXPECT_STR_EQ("this is a test", model_->GetText());
+  EXPECT_STR_EQ("THIS IS A TEST", textfield_->text());
+
+  EXPECT_TRUE(last_contents_.empty());
+}
+
+TEST_F(NativeTextfieldViewsTest, ModelChangesTestLowerCaseI18n) {
+  // Check if lower case conversion works for non-ASCII characters.
+  InitTextfield(Textfield::STYLE_LOWERCASE);
+  EXPECT_EQ(0U, textfield_->GetCursorPosition());
+
+  last_contents_.clear();
+  // Zenkaku Japanese "ABCabc"
+  textfield_->SetText(WideToUTF16(L"\xFF21\xFF22\xFF23\xFF41\xFF42\xFF43"));
+  EXPECT_EQ(0U, textfield_->GetCursorPosition());
+  // Zenkaku Japanese "abcabc"
+  EXPECT_EQ(WideToUTF16(L"\xFF41\xFF42\xFF43\xFF41\xFF42\xFF43"),
+            model_->GetText());
+  // Zenkaku Japanese "ABCabc"
+  EXPECT_EQ(WideToUTF16(L"\xFF21\xFF22\xFF23\xFF41\xFF42\xFF43"),
+            textfield_->text());
+  EXPECT_TRUE(last_contents_.empty());
+
+  // Zenkaku Japanese "XYZxyz"
+  textfield_->AppendText(WideToUTF16(L"\xFF38\xFF39\xFF3A\xFF58\xFF59\xFF5A"));
+  EXPECT_EQ(0U, textfield_->GetCursorPosition());
+  // Zenkaku Japanese "abcabcxyzxyz"
+  EXPECT_EQ(WideToUTF16(L"\xFF41\xFF42\xFF43\xFF41\xFF42\xFF43"
+                        L"\xFF58\xFF59\xFF5A\xFF58\xFF59\xFF5A"),
+            model_->GetText());
+  // Zenkaku Japanese "ABCabcXYZxyz"
+  EXPECT_EQ(WideToUTF16(L"\xFF21\xFF22\xFF23\xFF41\xFF42\xFF43"
+                        L"\xFF38\xFF39\xFF3A\xFF58\xFF59\xFF5A"),
+            textfield_->text());
+  EXPECT_TRUE(last_contents_.empty());
+}
+
+TEST_F(NativeTextfieldViewsTest, ModelChangesTestLowerCaseWithLocale) {
+  // Check if lower case conversion honors locale properly.
+  std::string locale = l10n_util::GetApplicationLocale("");
+  base::i18n::SetICUDefaultLocale("tr");
+
+  InitTextfield(Textfield::STYLE_LOWERCASE);
+  EXPECT_EQ(0U, textfield_->GetCursorPosition());
+
+  last_contents_.clear();
+  // Turkish 'I' should be converted to dotless 'i' (U+0131).
+  textfield_->SetText(WideToUTF16(L"I"));
+  EXPECT_EQ(0U, textfield_->GetCursorPosition());
+  EXPECT_EQ(WideToUTF16(L"\x0131"), model_->GetText());
+  EXPECT_EQ(WideToUTF16(L"I"), textfield_->text());
+  EXPECT_TRUE(last_contents_.empty());
+
+  base::i18n::SetICUDefaultLocale(locale);
+
+  // On default (en) locale, 'I' should be converted to 'i'.
+  textfield_->SetText(WideToUTF16(L"I"));
+  EXPECT_EQ(0U, textfield_->GetCursorPosition());
+  EXPECT_EQ(WideToUTF16(L"i"), model_->GetText());
+  EXPECT_EQ(WideToUTF16(L"I"), textfield_->text());
+  EXPECT_TRUE(last_contents_.empty());
+}
+
 TEST_F(NativeTextfieldViewsTest, KeyTest) {
   InitTextfield(Textfield::STYLE_DEFAULT);
   SendKeyEvent(ui::VKEY_C, true, false);
   EXPECT_STR_EQ("C", textfield_->text());
   EXPECT_STR_EQ("C", last_contents_);
   last_contents_.clear();
 
   SendKeyEvent(ui::VKEY_R, false, false);
   EXPECT_STR_EQ("Cr", textfield_->text());
   EXPECT_STR_EQ("Cr", last_contents_);
@@ skipping 1202 matching lines @@
 #else
   EXPECT_EQ(500U, textfield_->GetCursorPosition());
 #endif
 #endif  // !defined(OS_WIN)
 
   // Reset locale.
   base::i18n::SetICUDefaultLocale(locale);
 }
 
 }  // namespace views