Really make OmitFramePointers not go.

Really make OmitFramePointers not go.

TBR=eroman@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=121132

[kerz_chromium, 2012-02-08 23:10:28]

On 2012/02/08 23:09:45, kerz_chromium wrote:

That was fun.

[eroman, 2012-02-08 23:46:07]

https://chromiumcodereview.appspot.com/9358045/diff/4/build/internal/release_...
File build/internal/release_impl_official.gypi (right):

https://chromiumcodereview.appspot.com/9358045/diff/4/build/internal/release_...
build/internal/release_impl_official.gypi:13: 'AdditionalOptions': ['/Oy-'],
Can you order this right beside OmitFramePointers, and add an explanation why we
need to specify both? (for instance there is such a comment in
http://src.chromium.org/viewvc/chrome/trunk/src/build/common.gypi?r1=114893&r...)

Moreover, is it not sufficient to just specify win_release_OmitFramePointers ?

I'll defer this to Marc-Antoine for approval, but LGTM

[M-A Ruel, 2012-02-09 00:28:55]

It's caused by /O2?

lgtm
:wqa

[kerz_chromium, 2012-02-09 01:23:05]

On 2012/02/09 00:28:55, Marc-Antoine Ruel wrote:
> It's caused by /O2?
> 
> lgtm
> :wqa

Bah.

Also, added a quick bit of text and reordered for eroman above.

[commit-bot: I haz the power, 2012-02-09 01:23:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kerz@chromium.org/9358045/6001

[eroman, 2012-02-09 01:26:31]

lgtm.

BTW, I don't think the commit queue is going to make a difference here, since
this only applies to the official builds right?

:wq!

[kerz_chromium, 2012-02-09 01:27:32]

On 2012/02/09 01:26:31, eroman wrote:
> lgtm.
> 
> BTW, I don't think the commit queue is going to make a difference here, since
> this only applies to the official builds right?
> 
> :wq!

Shouldn't matter, just a way to get it in the tree.  The build tonight will pick
it up, assuming the CQ is actually doing things today.