Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 9358044: Fix build Linux ChromeOS GTK bot on the main waterfall. (Closed)

Created:
8 years, 10 months ago by Emmanuel Saint-loubert-Bié
Modified:
8 years, 10 months ago
Reviewers:
oshima
CC:
chromium-reviews
Visibility:
Public.

Description

Fix build Linux ChromeOS GTK bot on the main waterfall. TBR=oshima@chromium.org BUG=112962 TEST=Linux ChromeOS GTK bot not broken on the main waterfall Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=121091

Patch Set 1 #

Total comments: 4

Patch Set 2 : Applied Oshima's changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -27 lines) Patch
M build/all.gyp View 1 1 chunk +22 lines, -27 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Emmanuel Saint-loubert-Bié
PTAL
8 years, 10 months ago (2012-02-08 21:39:04 UTC) #1
oshima
https://chromiumcodereview.appspot.com/9358044/diff/1/build/all.gyp File build/all.gyp (right): https://chromiumcodereview.appspot.com/9358044/diff/1/build/all.gyp#newcode527 build/all.gyp:527: 'target_name': 'chromeos_builder', who is using this target? (chromeos/aura seems ...
8 years, 10 months ago (2012-02-08 21:59:32 UTC) #2
Emmanuel Saint-loubert-Bié
Linux ChromeOS GTK uses that target. This is the point of this CL
8 years, 10 months ago (2012-02-08 22:08:21 UTC) #3
oshima
https://chromiumcodereview.appspot.com/9358044/diff/1/build/all.gyp File build/all.gyp (right): https://chromiumcodereview.appspot.com/9358044/diff/1/build/all.gyp#newcode572 build/all.gyp:572: 'target_name': 'chromeos_builder', isn't this the target that chromeos gtk ...
8 years, 10 months ago (2012-02-08 22:11:16 UTC) #4
Emmanuel Saint-loubert-Bié
Oshima, I think we need to land this since we have a broken bot on ...
8 years, 10 months ago (2012-02-08 22:39:01 UTC) #5
Emmanuel Saint-loubert-Bié
Hi Oshima, I cannot find any use of the chromeos_builder in any build script except ...
8 years, 10 months ago (2012-02-08 22:58:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/saintlou@chromium.org/9358044/6002
8 years, 10 months ago (2012-02-08 23:12:21 UTC) #7
oshima
8 years, 10 months ago (2012-02-08 23:55:40 UTC) #8
LGTM

Powered by Google App Engine
This is Rietveld 408576698