Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8568)

Unified Diff: chrome/browser/resources/ntp4/new_tab.js

Issue 9358031: Added new adaptive "Suggest" tab on the New Tab Page, behing the flag, for the experiments. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Removed "most visited" references Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/ntp4/new_tab.js
diff --git a/chrome/browser/resources/ntp4/new_tab.js b/chrome/browser/resources/ntp4/new_tab.js
index 257125dd066cb61015c37a0104e05786b3a6b9c2..e6056d1342f6b005585ee8d7748fc54438afdcb8 100644
--- a/chrome/browser/resources/ntp4/new_tab.js
+++ b/chrome/browser/resources/ntp4/new_tab.js
@@ -113,6 +113,13 @@ cr.define('ntp4', function() {
false);
chrome.send('getMostVisited');
+ if (templateData.isSuggestedPageEnabled) {
+ newTabView.appendTilePage(new ntp4.SuggestedPage(),
+ localStrings.getString('suggested'),
+ false);
+ chrome.send('getSuggested');
+ }
+
if (templateData.isWebStoreExperimentEnabled) {
var webstoreLink = localStrings.getString('webStoreLink');
var url = appendParam(webstoreLink, 'utm_source', 'chrome-ntp-launcher');
@@ -419,6 +426,10 @@ cr.define('ntp4', function() {
function setMostVisitedPages(data, hasBlacklistedUrls) {
newTabView.mostVisitedPage.data = data;
cr.dispatchSimpleEvent(document, 'sectionready', true, true);
+ }
+
+ function setSuggestedPages(data, hasBlacklistedUrls) {
+ newTabView.suggestedPage.data = data;
}
/**
@@ -529,8 +540,9 @@ cr.define('ntp4', function() {
onLoad: onLoad,
leaveRearrangeMode: leaveRearrangeMode,
saveAppPageName: saveAppPageName,
- setAppToBeHighlighted: setAppToBeHighlighted,
+ setAppToBeHighlighted: setAppToBeHighlighted,
setMostVisitedPages: setMostVisitedPages,
+ setSuggestedPages: setSuggestedPages,
setRecentlyClosedTabs: setRecentlyClosedTabs,
setStripeColor: setStripeColor,
showNotification: showNotification,
@@ -545,8 +557,10 @@ cr.define('ntp4', function() {
var getAppsCallback = ntp4.getAppsCallback;
var appsPrefChangeCallback = ntp4.appsPrefChangeCallback;
var themeChanged = ntp4.themeChanged;
-var recentlyClosedTabs = ntp4.setRecentlyClosedTabs;
-var setMostVisitedPages = ntp4.setMostVisitedPages;
+var recentlyClosedTabs = ntp4.setRecentlyClosedTabs;
+var setMostVisitedPages = ntp4.setMostVisitedPages;
+var setSuggestedPages = ntp4.setSuggestedPages;
Evan Stade 2012/02/09 01:54:23 do not add to this list. see TODO
GeorgeY 2012/02/10 00:00:36 Done.
+var setStripeColor = ntp4.setStripeColor;
var updateLogin = ntp4.updateLogin;
document.addEventListener('DOMContentLoaded', ntp4.onLoad);

Powered by Google App Engine
This is Rietveld 408576698