Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Unified Diff: chrome/browser/resources/ntp4/new_tab.js

Issue 9358031: Added new adaptive "Suggest" tab on the New Tab Page, behing the flag, for the experiments. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed Dan's comments Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/ntp4/new_tab.js
diff --git a/chrome/browser/resources/ntp4/new_tab.js b/chrome/browser/resources/ntp4/new_tab.js
index 621157ee7f597d4c29cb691793ae844d09742c0c..74604ba0892bf1db7836874a2448ac38606a0933 100644
--- a/chrome/browser/resources/ntp4/new_tab.js
+++ b/chrome/browser/resources/ntp4/new_tab.js
@@ -113,6 +113,12 @@ cr.define('ntp4', function() {
false);
chrome.send('getMostVisited');
+ if (templateData.isSuggestionsPageEnabled) {
+ var suggestions_script = document.createElement('script');
+ suggestions_script.src = 'suggestions_page.js';
+ document.querySelector('head').appendChild(suggestions_script);
Dan Beam 2012/02/28 22:30:12 Why not something along the lines of suggestion
GeorgeY 2012/02/29 00:15:45 Oh, this works as well, done.
+ }
+
var webstoreLink = localStrings.getString('webStoreLink');
if (templateData.isWebStoreExperimentEnabled) {
var url = appendParam(webstoreLink, 'utm_source', 'chrome-ntp-launcher');
@@ -423,6 +429,10 @@ cr.define('ntp4', function() {
function setMostVisitedPages(data, hasBlacklistedUrls) {
newTabView.mostVisitedPage.data = data;
cr.dispatchSimpleEvent(document, 'sectionready', true, true);
+ }
+
+ function setSuggestionsPages(data, hasBlacklistedUrls) {
+ newTabView.suggestionsPage.data = data;
}
/**
@@ -513,6 +523,10 @@ cr.define('ntp4', function() {
return newTabView.cardSlider;
}
+ function getNewTabView() {
+ return newTabView;
+ }
+
function leaveRearrangeMode() {
return newTabView.leaveRearrangeMode.apply(newTabView, arguments);
}
@@ -535,11 +549,13 @@ cr.define('ntp4', function() {
getAppsCallback: getAppsCallback,
getAppsPageIndex: getAppsPageIndex,
getCardSlider: getCardSlider,
+ getNewTabView: getNewTabView,
onLoad: onLoad,
leaveRearrangeMode: leaveRearrangeMode,
saveAppPageName: saveAppPageName,
- setAppToBeHighlighted: setAppToBeHighlighted,
+ setAppToBeHighlighted: setAppToBeHighlighted,
setMostVisitedPages: setMostVisitedPages,
+ setSuggestionsPages: setSuggestionsPages,
setRecentlyClosedTabs: setRecentlyClosedTabs,
setStripeColor: setStripeColor,
showNotification: showNotification,
@@ -554,8 +570,8 @@ cr.define('ntp4', function() {
var getAppsCallback = ntp4.getAppsCallback;
var appsPrefChangeCallback = ntp4.appsPrefChangeCallback;
var themeChanged = ntp4.themeChanged;
-var recentlyClosedTabs = ntp4.setRecentlyClosedTabs;
-var setMostVisitedPages = ntp4.setMostVisitedPages;
+var recentlyClosedTabs = ntp4.setRecentlyClosedTabs;
+var setMostVisitedPages = ntp4.setMostVisitedPages;
var updateLogin = ntp4.updateLogin;
document.addEventListener('DOMContentLoaded', ntp4.onLoad);

Powered by Google App Engine
This is Rietveld 408576698