chrome/browser/ui/webui/ntp/new_tab_page_handler.h - Issue 9358031: Added new adaptive "Suggest" tab on the New Tab Page, behing the flag, for the experiments.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/ntp/new_tab_page_handler.h

Issue 9358031: Added new adaptive "Suggest" tab on the New Tab Page, behing the flag, for the experiments. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: added dynamic loading of the JS and CSS Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/ntp4/suggestions_page.js ('K') | « chrome/browser/resources/ntp4/suggestions_page.js ('k') | chrome/browser/ui/webui/ntp/new_tab_page_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/ntp/new_tab_page_handler.h

diff --git a/chrome/browser/ui/webui/ntp/new_tab_page_handler.h b/chrome/browser/ui/webui/ntp/new_tab_page_handler.h

index 9f6e8e13be8f48e57c3ec79e32057395bdba445d..a18d7c0edef5aefcc34a9c2d8861938c700876d8 100644

--- a/chrome/browser/ui/webui/ntp/new_tab_page_handler.h

+++ b/chrome/browser/ui/webui/ntp/new_tab_page_handler.h

@@ -65,7 +65,8 @@ class NewTabPageHandler : public content::WebUIMessageHandler {

MOST_VISITED_PAGE_ID = 1 << kPageIdOffset,

APPS_PAGE_ID = 2 << kPageIdOffset,

BOOKMARKS_PAGE_ID = 3 << kPageIdOffset,

- LAST_PAGE_ID = BOOKMARKS_PAGE_ID

+ SUGGESTIONS_PAGE_ID = 4 << kPageIdOffset,

Evan Stade 2012/02/17 20:07:35 you must update histograms.xml as well.

GeorgeY 2012/02/21 23:32:23 Should I do this in the same cl? I always thought

Evan Stade 2012/02/23 02:10:20 no, you have to do it in a separate CL, but you ca

GeorgeY 2012/02/24 01:52:07 cl 3970015

+ LAST_PAGE_ID = SUGGESTIONS_PAGE_ID

};

static const int kHistogramEnumerationMax =

(LAST_PAGE_ID >> kPageIdOffset) + 1;