Added new adaptive "Suggest" tab on the New Tab Page, behing the flag, for the experiments.

chrome/browser/resources/ntp4/page_list_view.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview PageListView implementation.
  * PageListView manages page list, dot list, switcher buttons and handles apps
  * pages callbacks from backend.
  *
  * Note that you need to have AppLauncherHandler in your WebUI to use this code.
@@ skipping 41 matching lines @@
      */
     tilePages: undefined,
 
     /**
      * A list of all 'apps-page' elements.
      * @type {!NodeList|undefined}
      */
     appsPages: undefined,
 
     /**
+     * The Suggestions page.
+     * @type {!Element|undefined}
+     */
+    suggestionsPage: undefined,
+
+    /**
      * The Most Visited page.
      * @type {!Element|undefined}
      */
     mostVisitedPage: undefined,
 
     /**
      * The 'dots-list' element.
      * @type {!Element|undefined}
      */
     dotList: undefined,
@@ skipping 120 matching lines @@
      * @param {string} title The title of the tile page.
      * @param {bool} titleIsEditable If true, the title can be changed.
      * @param {TilePage} opt_refNode Optional reference node to insert in front
      *     of.
      * When opt_refNode is falsey, |page| will just be appended to the end of
      * the page list.
      */
     appendTilePage: function(page, title, titleIsEditable, opt_refNode) {
       if (opt_refNode) {
         var refIndex = this.getTilePageIndex(opt_refNode);
-        this.cardSlider.insertCardAtIndex(page, refIndex);
+        this.cardSlider.addCardAtIndex(page, refIndex);
       } else {
         this.cardSlider.appendCard(page);
       }
 
       // Remember special MostVisitedPage.
       if (typeof ntp4.MostVisitedPage != 'undefined' &&
           page instanceof ntp4.MostVisitedPage) {
         assert(this.tilePages.length == 1,
                'MostVisitedPage should be added as first tile page');
         this.mostVisitedPage = page;
       }
 
+      if (typeof ntp4.SuggestionsPage != 'undefined' &&
+          page instanceof ntp4.SuggestionsPage) {
+        this.suggestionsPage = page;
+      }
+
       // If we're appending an AppsPage and it's a temporary page, animate it.
       var animate = page instanceof ntp4.AppsPage &&
                     page.classList.contains('temporary');
       // Make a deep copy of the dot template to add a new one.
       var newDot = new ntp4.NavDot(page, title, titleIsEditable, animate);
       page.navigationDot = newDot;
       this.dotList.insertBefore(newDot,
                                 opt_refNode ? opt_refNode.navigationDot : null);
       // Set a tab index on the first dot.
       if (this.dotList.dots.length == 1)
@@ skipping 87 matching lines @@
 
       // Sort by launch ordinal
       apps.sort(function(a, b) {
         return a.app_launch_ordinal > b.app_launch_ordinal ? 1 :
           a.app_launch_ordinal < b.app_launch_ordinal ? -1 : 0;
       });
 
       // An app to animate (in case it was just installed).
       var highlightApp;
 
+      // If there are any pages after the apps, add new pages before them.
+      var nextPageAfterApps = null;
+      for (var i = 1; i < this.tilePages.length; ++i) {
+        if (this.tilePages[i - 1] instanceof ntp4.AppsPage &&
+            !(this.tilePages[i] instanceof ntp4.AppsPage)) {
+          nextPageAfterApps = this.tilePages[i];
+          break;
+        }
+      }
+
       // Add the apps, creating pages as necessary
       for (var i = 0; i < apps.length; i++) {
         var app = apps[i];
         var pageIndex = app.page_index || 0;
         while (pageIndex >= this.appsPages.length) {
           var pageName = localStrings.getString('appDefaultPageName');
           if (this.appsPages.length < pageNames.length)
             pageName = pageNames[this.appsPages.length];
 
           var origPageCount = this.appsPages.length;
-          this.appendTilePage(new ntp4.AppsPage(), pageName, true);
+          this.appendTilePage(new ntp4.AppsPage(), pageName, true,
+                              nextPageAfterApps);
           // Confirm that appsPages is a live object, updated when a new page is
           // added (otherwise we'd have an infinite loop)
           assert(this.appsPages.length == origPageCount + 1,
                  'expected new page');
         }
 
         if (app.id == this.highlightAppId)
           highlightApp = app;
         else
           this.appsPages[pageIndex].appendApp(app, false);
@@ skipping 79 matching lines @@
       switch (this.shownPage) {
         case templateData['apps_page_id']:
           this.cardSlider.selectCardByValue(
               this.appsPages[Math.min(this.shownPageIndex,
                                       this.appsPages.length - 1)]);
           break;
         case templateData['most_visited_page_id']:
           if (this.mostVisitedPage)
             this.cardSlider.selectCardByValue(this.mostVisitedPage);
           break;
+        case templateData['suggestions_page_id']:
+          if (this.suggestionsPage)
+            this.cardSlider.selectCardByValue(this.suggestionsPage);
+          break;
       }
     },
 
     /**
      * Called whenever tiles should be re-arranging themselves out of the way
      * of a moving or insert tile.
      */
     enterRearrangeMode: function() {
       var tempPage = new ntp4.AppsPage();
       tempPage.classList.add('temporary');
@@ skipping 78 matching lines @@
      * Returns the index of the given apps page.
      * @param {AppsPage} page The AppsPage we wish to find.
      * @return {number} The index of |page| or -1 if it is not in the
      *    collection.
      */
     getAppsPageIndex: function(page) {
       return Array.prototype.indexOf.call(this.appsPages, page);
     },
 
     /**
+     * Returns the first Apps page object in pageList, so pages could be added
+     * before that.
+     * @return {page} First Apps page object in pageList or null.
+     */
+    getFirstAppsPage: function() {
+      if (typeof this.tilePages == 'undefined')

[Dan Beam, 2012/02/28 22:30:12]

I don't see how this can ever be undefined (as initialize() will always be
called first synchronously before loading the script that would use this).

[GeorgeY, 2012/02/29 00:15:45]

Function removed

+        return null;
+      for (var i = 0; i < this.tilePages.length; ++i) {
+        if (this.tilePages[i] instanceof ntp4.AppsPage)

[Dan Beam, 2012/02/28 22:30:12]

assuming this.appsPages and this.tilePages always exists, this does the same
thing:
  this.appsPages[0]
or
  this.appsPages[0] || null
if you really want to return null

+          return this.tilePages[i];
+      }
+      return null;
+    },
+
+    /**
      * Handler for cardSlider:card_changed events from this.cardSlider.
      * @param {Event} e The cardSlider:card_changed event.
      * @private
      */
     onCardChanged_: function(e) {
       var page = e.cardSlider.currentCardValue;
 
       // Don't change shownPage until startup is done (and page changes actually
       // reflect user actions).
       if (!this.isStartingUp_()) {
         if (page.classList.contains('apps-page')) {
           this.shownPage = templateData.apps_page_id;
           this.shownPageIndex = this.getAppsPageIndex(page);
         } else if (page.classList.contains('most-visited-page')) {
           this.shownPage = templateData.most_visited_page_id;
           this.shownPageIndex = 0;
+        } else if (page.classList.contains('suggestions-page')) {
+          this.shownPage = templateData.suggestions_page_id;
+          this.shownPageIndex = 0;
         } else {
           console.error('unknown page selected');
         }
         chrome.send('pageSelected', [this.shownPage, this.shownPageIndex]);
       }
 
       // Update the active dot
       var curDot = this.dotList.getElementsByClassName('selected')[0];
       if (curDot)
         curDot.classList.remove('selected');
       page.navigationDot.classList.add('selected');
       this.updatePageSwitchers();
     },
 
     /**
      * Listen for card additions to update the page switchers or the current
      * card accordingly.
      * @param {Event} e A card removed or added event.
      */
     onCardAdded_: function(e) {
       // When the second arg passed to insertBefore is falsey, it acts just like
       // appendChild.
       this.pageList.insertBefore(e.addedCard, this.tilePages[e.addedIndex]);
       if (!this.isStartingUp_())
         this.updatePageSwitchers();

[Dan Beam, 2012/02/28 22:30:12]

I think this is a better place to call updateSliderCard()

  if (!this.isStartingUp_()) {
    this.updatePageSwitchers();
    this.updateSliderCards();
  }

[GeorgeY, 2012/02/29 00:15:45]

Tried it (and removed calls to updateSliderCards() everywhere else) and the page
gets completely broken in some cases 

[Dan Beam, 2012/02/29 00:47:02]

Weird, OK, it's fine to omit this.

     },
 
     /**
      * Listen for card removals to update the page switchers or the current card
      * accordingly.
      * @param {Event} e A card removed or added event.
      */
     onCardRemoved_: function(e) {
       e.removedCard.parentNode.removeChild(e.removedCard);
       if (!this.isStartingUp_())
@@ skipping 81 matching lines @@
       if (page.navigationDot)
         page.navigationDot.remove(opt_animate);
       this.cardSlider.removeCard(page);
     },
   };
 
   return {
     PageListView: PageListView
   };
 });